[PATCH] drm/i915/guc: Reduce verbosity on log overflows

[PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Chris Wilson]

If the user is clearing the log buffer too slowly, we overflow. As this
is an expected condition, and the driver tries to handle it, reduce the
error message down to a notice.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_guc_log.c b/drivers/gpu/drm/i915/intel_guc_log.c
index bf1446629703..e3b83ecb90b5 100644
--- a/drivers/gpu/drm/i915/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/intel_guc_log.c
@@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct intel_guc_log *log,
 			/* buffer_full_cnt is a 4 bit counter */
 			log->stats[type].sampled_overflow += 16;
 		}
-		DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
+
+		dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
+				       "GuC log buffer overflow\n");
 	}
 
 	return overflow;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Tvrtko Ursulin]

On 17/06/2019 11:09, Chris Wilson wrote:
> If the user is clearing the log buffer too slowly, we overflow. As this
> is an expected condition, and the driver tries to handle it, reduce the
> error message down to a notice.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_guc_log.c b/drivers/gpu/drm/i915/intel_guc_log.c
> index bf1446629703..e3b83ecb90b5 100644
> --- a/drivers/gpu/drm/i915/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct intel_guc_log *log,
>   			/* buffer_full_cnt is a 4 bit counter */
>   			log->stats[type].sampled_overflow += 16;
>   		}
> -		DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
> +
> +		dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
> +				       "GuC log buffer overflow\n");
>   	}
>   
>   	return overflow;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Maybe we could even go debug, although I not sure if userspace is 
expected to look at dmesg to detect overflows or if the thing has some 
marker it writes into the file in that case. I don't see it so that's 
probably a slight flaw.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Chris Wilson]

Quoting Tvrtko Ursulin (2019-06-17 15:21:54)
> 
> On 17/06/2019 11:09, Chris Wilson wrote:
> > If the user is clearing the log buffer too slowly, we overflow. As this
> > is an expected condition, and the driver tries to handle it, reduce the
> > error message down to a notice.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >   drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_guc_log.c b/drivers/gpu/drm/i915/intel_guc_log.c
> > index bf1446629703..e3b83ecb90b5 100644
> > --- a/drivers/gpu/drm/i915/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> > @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct intel_guc_log *log,
> >                       /* buffer_full_cnt is a 4 bit counter */
> >                       log->stats[type].sampled_overflow += 16;
> >               }
> > -             DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
> > +
> > +             dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
> > +                                    "GuC log buffer overflow\n");
> >       }
> >   
> >       return overflow;
> > 
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Maybe we could even go debug, although I not sure if userspace is 
> expected to look at dmesg to detect overflows or if the thing has some 
> marker it writes into the file in that case. I don't see it so that's 
> probably a slight flaw.

It wasn't completely clear to me how well userspace did handle this (I
haven't run the debug tools myself) so settled for leaving a hint
visible in dmesg. Ideally, if we are expecting userspace to be handling
the ringbuf interface, it should be coping with the overflows then this
is just noise and can be removed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Michal Wajdeczko]

On Mon, 17 Jun 2019 12:09:17 +0200, Chris Wilson  
<chris@chris-wilson.co.uk> wrote:

> If the user is clearing the log buffer too slowly, we overflow. As this
> is an expected condition, and the driver tries to handle it, reduce the
> error message down to a notice.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc_log.c  
> b/drivers/gpu/drm/i915/intel_guc_log.c
> index bf1446629703..e3b83ecb90b5 100644
> --- a/drivers/gpu/drm/i915/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct  
> intel_guc_log *log,
>  			/* buffer_full_cnt is a 4 bit counter */
>  			log->stats[type].sampled_overflow += 16;
>  		}
> -		DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
> +
> +		dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
> +				       "GuC log buffer overflow\n");

While this change alone is not harmful, I'm afraid that there might
be another reason why we see this message : once buffer_full_cnt is
turned on by the fw and then we reset the Guc, this field may have
stale value as it is not cleared by us/uc and we may wrongly assume
that there was an overflow.

>  	}
> 	return overflow;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Chris Wilson]

Quoting Michal Wajdeczko (2019-06-17 15:38:53)
> On Mon, 17 Jun 2019 12:09:17 +0200, Chris Wilson  
> <chris@chris-wilson.co.uk> wrote:
> 
> > If the user is clearing the log buffer too slowly, we overflow. As this
> > is an expected condition, and the driver tries to handle it, reduce the
> > error message down to a notice.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_guc_log.c  
> > b/drivers/gpu/drm/i915/intel_guc_log.c
> > index bf1446629703..e3b83ecb90b5 100644
> > --- a/drivers/gpu/drm/i915/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> > @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct  
> > intel_guc_log *log,
> >                       /* buffer_full_cnt is a 4 bit counter */
> >                       log->stats[type].sampled_overflow += 16;
> >               }
> > -             DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
> > +
> > +             dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
> > +                                    "GuC log buffer overflow\n");
> 
> While this change alone is not harmful, I'm afraid that there might
> be another reason why we see this message : once buffer_full_cnt is
> turned on by the fw and then we reset the Guc, this field may have
> stale value as it is not cleared by us/uc and we may wrongly assume
> that there was an overflow.

Fwiw, at the moment, it is being thrown by the cat /debug/dri/0/* test.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/guc: Reduce verbosity on log overflows

[Patchwork]

== Series Details ==

Series: drm/i915/guc: Reduce verbosity on log overflows
URL   : https://patchwork.freedesktop.org/series/62195/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6287 -> Patchwork_13306
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/

Known issues
------------

  Here are the changes found in Patchwork_13306 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap_gtt@basic-wc:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/fi-icl-u3/igt@gem_mmap_gtt@basic-wc.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/fi-icl-u3/igt@gem_mmap_gtt@basic-wc.html

  * igt@gem_mmap_gtt@basic-write-read-distinct:
    - fi-icl-dsi:         [PASS][3] -> [INCOMPLETE][4] ([fdo#107713])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/fi-icl-dsi/igt@gem_mmap_gtt@basic-write-read-distinct.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/fi-icl-dsi/igt@gem_mmap_gtt@basic-write-read-distinct.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][5] -> [FAIL][6] ([fdo#109485])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][7] -> [FAIL][8] ([fdo#103167])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-no-display:
    - fi-icl-u3:          [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/fi-icl-u3/igt@i915_module_load@reload-no-display.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/fi-icl-u3/igt@i915_module_load@reload-no-display.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485


Participating hosts (48 -> 36)
------------------------------

  Additional (1): fi-icl-guc 
  Missing    (13): fi-kbl-soraka fi-cml-u2 fi-ilk-m540 fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-8809g fi-skl-iommu fi-pnv-d510 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6287 -> Patchwork_13306

  CI_DRM_6287: 3765c2bb2bf60f35709fba4c23070e2b74e14247 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13306: 7c9d9dce131511a6f161528272f69f5aedf11528 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

7c9d9dce1315 drm/i915/guc: Reduce verbosity on log overflows

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for drm/i915/guc: Reduce verbosity on log overflows

[Patchwork]

== Series Details ==

Series: drm/i915/guc: Reduce verbosity on log overflows
URL   : https://patchwork.freedesktop.org/series/62195/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6287_full -> Patchwork_13306_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_13306_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_13306_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_13306_full:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - shard-kbl:          NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl4/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_13306_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-apl:          [PASS][2] -> [DMESG-WARN][3] ([fdo#108566]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-apl1/igt@gem_ctx_isolation@bcs0-s3.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-apl5/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
    - shard-apl:          [PASS][4] -> [DMESG-WARN][5] ([fdo#110913 ]) +2 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
    - shard-snb:          [PASS][6] -> [DMESG-WARN][7] ([fdo#110789] / [fdo#110913 ])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-kbl:          [PASS][8] -> [DMESG-WARN][9] ([fdo#110913 ])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [PASS][10] -> [DMESG-WARN][11] ([fdo#110913 ]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_pm_rpm@basic-rte:
    - shard-iclb:         [PASS][12] -> [INCOMPLETE][13] ([fdo#107713] / [fdo#108840])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb7/igt@i915_pm_rpm@basic-rte.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb2/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_selftest@live_evict:
    - shard-kbl:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103665])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl2/igt@i915_selftest@live_evict.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl4/igt@i915_selftest@live_evict.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +3 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [PASS][18] -> [FAIL][19] ([fdo#105767])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][20] -> [FAIL][21] ([fdo#103355])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_flip@2x-absolute-wf_vblank-interruptible:
    - shard-hsw:          [PASS][22] -> [SKIP][23] ([fdo#109271])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-hsw8/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-hsw1/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          [PASS][24] -> [INCOMPLETE][25] ([fdo#105411])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb7/igt@kms_flip@flip-vs-suspend.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-badstride:
    - shard-iclb:         [PASS][26] -> [FAIL][27] ([fdo#103167]) +4 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-badstride.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-badstride.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [PASS][28] -> [FAIL][29] ([fdo#103166])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][30] -> [SKIP][31] ([fdo#109441]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb3/igt@kms_psr@psr2_cursor_render.html

  * igt@tools_test@tools_test:
    - shard-kbl:          [PASS][32] -> [SKIP][33] ([fdo#109271])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl3/igt@tools_test@tools_test.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl7/igt@tools_test@tools_test.html

  
#### Possible fixes ####

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][34] ([fdo#110854]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb3/igt@gem_exec_balancer@smoke.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb1/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_blt@normal-min:
    - shard-apl:          [INCOMPLETE][36] ([fdo#103927]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-apl2/igt@gem_exec_blt@normal-min.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-apl8/igt@gem_exec_blt@normal-min.html

  * igt@gem_mmap_gtt@hang:
    - shard-apl:          [DMESG-WARN][38] ([fdo#110913 ]) -> [PASS][39] +3 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-apl4/igt@gem_mmap_gtt@hang.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-apl8/igt@gem_mmap_gtt@hang.html
    - shard-snb:          [INCOMPLETE][40] ([fdo#105411]) -> [PASS][41]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb6/igt@gem_mmap_gtt@hang.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb4/igt@gem_mmap_gtt@hang.html

  * igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
    - shard-snb:          [DMESG-WARN][42] ([fdo#110789] / [fdo#110913 ]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-snb:          [DMESG-WARN][44] ([fdo#110913 ]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-kbl:          [DMESG-WARN][46] ([fdo#110913 ]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl3/igt@gem_userptr_blits@sync-unmap-cycles.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl7/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_suspend@fence-restore-tiled2untiled:
    - shard-apl:          [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +2 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [SKIP][50] ([fdo#109271]) -> [PASS][51] +31 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-hsw1/igt@kms_flip@2x-plain-flip.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-hsw8/igt@kms_flip@2x-plain-flip.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53] +1 similar issue
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         [FAIL][54] ([fdo#103167]) -> [PASS][55] +8 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-skl:          [INCOMPLETE][56] ([fdo#104108]) -> [PASS][57]
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-skl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [SKIP][58] ([fdo#109441]) -> [PASS][59] +1 similar issue
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb4/igt@kms_psr@psr2_basic.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb2/igt@kms_psr@psr2_basic.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][60] ([fdo#99912]) -> [PASS][61]
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-kbl4/igt@kms_setmode@basic.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-kbl1/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [FAIL][62] ([fdo#100047]) -> [PASS][63]
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb3/igt@kms_sysfs_edid_timing.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb1/igt@kms_sysfs_edid_timing.html

  
#### Warnings ####

  * igt@i915_pm_rpm@modeset-pc8-residency-stress:
    - shard-iclb:         [INCOMPLETE][64] ([fdo#107713] / [fdo#108840]) -> [SKIP][65] ([fdo#109293])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6287/shard-iclb7/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/shard-iclb6/igt@i915_pm_rpm@modeset-pc8-residency-stress.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6287 -> Patchwork_13306

  CI_DRM_6287: 3765c2bb2bf60f35709fba4c23070e2b74e14247 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13306: 7c9d9dce131511a6f161528272f69f5aedf11528 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13306/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Chris Wilson]

Quoting Michal Wajdeczko (2019-06-17 15:38:53)
> On Mon, 17 Jun 2019 12:09:17 +0200, Chris Wilson  
> <chris@chris-wilson.co.uk> wrote:
> 
> > If the user is clearing the log buffer too slowly, we overflow. As this
> > is an expected condition, and the driver tries to handle it, reduce the
> > error message down to a notice.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_guc_log.c  
> > b/drivers/gpu/drm/i915/intel_guc_log.c
> > index bf1446629703..e3b83ecb90b5 100644
> > --- a/drivers/gpu/drm/i915/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/intel_guc_log.c
> > @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct  
> > intel_guc_log *log,
> >                       /* buffer_full_cnt is a 4 bit counter */
> >                       log->stats[type].sampled_overflow += 16;
> >               }
> > -             DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
> > +
> > +             dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
> > +                                    "GuC log buffer overflow\n");
> 
> While this change alone is not harmful, I'm afraid that there might
> be another reason why we see this message : once buffer_full_cnt is
> turned on by the fw and then we reset the Guc, this field may have
> stale value as it is not cleared by us/uc and we may wrongly assume
> that there was an overflow.

So yay/nay on silencing the test output so I can blissfully ignore it in
bugzilla?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/guc: Reduce verbosity on log overflows

[Michal Wajdeczko]

On Tue, 18 Jun 2019 12:24:30 +0200, Chris Wilson  
<chris@chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2019-06-17 15:38:53)
>> On Mon, 17 Jun 2019 12:09:17 +0200, Chris Wilson
>> <chris@chris-wilson.co.uk> wrote:
>>
>> > If the user is clearing the log buffer too slowly, we overflow. As  
>> this
>> > is an expected condition, and the driver tries to handle it, reduce  
>> the
>> > error message down to a notice.
>> >
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> > ---
>> >  drivers/gpu/drm/i915/intel_guc_log.c | 4 +++-
>> >  1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_guc_log.c
>> > b/drivers/gpu/drm/i915/intel_guc_log.c
>> > index bf1446629703..e3b83ecb90b5 100644
>> > --- a/drivers/gpu/drm/i915/intel_guc_log.c
>> > +++ b/drivers/gpu/drm/i915/intel_guc_log.c
>> > @@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct
>> > intel_guc_log *log,
>> >                       /* buffer_full_cnt is a 4 bit counter */
>> >                       log->stats[type].sampled_overflow += 16;
>> >               }
>> > -             DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
>> > +
>> > +              
>> dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
>> > +                                    "GuC log buffer overflow\n");
>>
>> While this change alone is not harmful, I'm afraid that there might
>> be another reason why we see this message : once buffer_full_cnt is
>> turned on by the fw and then we reset the Guc, this field may have
>> stale value as it is not cleared by us/uc and we may wrongly assume
>> that there was an overflow.
>
> So yay/nay on silencing the test output so I can blissfully ignore it in
> bugzilla?

OK to merge, we can debug extra 'notice' logs separately

Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx