Re: [External] Power-on monitor for phosphor-hwmon question

[Matt Spinler <mspinler@linux.ibm.com>]

On 12/2/2019 9:15 AM, Ivan Li11 wrote:
>> -----Original Message-----
>> From: Ivan Li11
>> Sent: Wednesday, November 27, 2019 10:26 PM
>> To: 'Matt Spinler' <mspinler@linux.ibm.com>; openbmc@lists.ozlabs.org
>> Subject: RE: [External] Power-on monitor for phosphor-hwmon question
>>
>>> -----Original Message-----
>>> From: Matt Spinler <mspinler@linux.ibm.com>
>>> Sent: Tuesday, October 22, 2019 9:24 PM
>>> To: Ivan Li11 <rli11@lenovo.com>; openbmc@lists.ozlabs.org
>>> Subject: Re: [External] Power-on monitor for phosphor-hwmon question
>>>
>>>
>>>
>>> On 10/21/2019 6:02 AM, Ivan Li11 wrote:
>>>> Hi Team,
>>>>
>>>> Does anyone have suggestion for this ?
>>>>
>>> Hi, you're right, it doesn't support that yet.  We've had a few
>>> internal discussions about how to handle that gracefully, though our
>>> platforms don't use sel-logger, but nothing solid came out of them and
>>> we don't have anything scheduled yet.
>>>
>>> It would be easy enough to have a watch on the PGOOD property, and
>>> then do you what you want, like maybe turning off the thresholds.
>>>
>>> I heard that the d-bus sensors repository has some sort of support for
>>> this, but since we don't use it I'm not sure what all that entails. I
>>> think it may also force you to replace phosphor-inventor-manager with
>> entity-manager.
>> Hi Matt,
>> We can use dbus-match mechanism in phosphor-hwmon to turn on/off the
>> thresholds just like what dbus-sensors repository does in the following link:
>> https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
>> a59e4b1cf86b8a6/src/Utils.cpp#L141
>>
>> If it's ok for you, I'll work on it and send patch for you review.
>> Please help to comment on it.
>>
> Hi Matt,
> Could you help to comment on this proposal.
> Thanks your great support in advance.

That sounds good to me.  Thanks!


>
>>>> Thanks your great support in advance.
>>>>
>>>> *From:*openbmc <openbmc-bounces+rli11=lenovo.com@lists.ozlabs.org>
>>> *On
>>>> Behalf Of *Ivan Li11
>>>> *Sent:* Friday, October 18, 2019 5:59 PM
>>>> *To:* openbmc@lists.ozlabs.org
>>>> *Subject:* [External] Power-on monitor for phosphor-hwmon question
>>>>
>>>> Hi Team,
>>>>
>>>> We found that there's no power-on monitor mechanism in
>>> phosphor-hwmon.
>>>> https://github.com/openbmc/phosphor-hwmon
>>>>
>>>> And it will cause incorrect threshold logs to be added to journal
>>>> log by 'sel-logger' when system is in power off(S5) state.
>>>>
>>>> Is there any plan to implement it? Or other repository we can refer to ?
>>>>
>>>> Thanks,
>>>>
>>>> Ivan
>>>>