Re: [External] Power-on monitor for phosphor-hwmon question

[James Feist <james.feist@linux.intel.com>]

On 11/20/19 8:28 AM, Ivan Li11 wrote:
>> -----Original Message-----
>> From: Ivan Li11
>> Sent: Thursday, November 7, 2019 4:35 PM
>> To: 'James Feist' <james.feist@linux.intel.com>; Matt Spinler
>> <mspinler@linux.ibm.com>; openbmc@lists.ozlabs.org
>> Subject: RE: [External] Power-on monitor for phosphor-hwmon question
>>
>>> -----Original Message-----
>>> From: James Feist <james.feist@linux.intel.com>
>>> Sent: Thursday, November 7, 2019 7:39 AM
>>> To: Ivan Li11 <rli11@lenovo.com>; Matt Spinler
>>> <mspinler@linux.ibm.com>; openbmc@lists.ozlabs.org
>>> Subject: Re: [External] Power-on monitor for phosphor-hwmon question
>>>
>>> On 11/5/19 11:25 PM, Ivan Li11 wrote:
>>>>> -----Original Message-----
>>>>> From: James Feist <james.feist@linux.intel.com>
>>>>> Sent: Tuesday, October 22, 2019 11:51 PM
>>>>> To: Matt Spinler <mspinler@linux.ibm.com>; Ivan Li11
>>>>> <rli11@lenovo.com>; openbmc@lists.ozlabs.org
>>>>> Subject: Re: [External] Power-on monitor for phosphor-hwmon
>>>>> question
>>>>>
>>>>> On 10/22/19 6:23 AM, Matt Spinler wrote:
>>>>>>
>>>>>>
>>>>>> On 10/21/2019 6:02 AM, Ivan Li11 wrote:
>>>>>>>
>>>>>>> Hi Team,
>>>>>>>
>>>>>>> Does anyone have suggestion for this ?
>>>>>>>
>>>>>> Hi, you're right, it doesn't support that yet.  We've had a few
>>>>>> internal discussions about how to handle that gracefully, though
>>>>>> our platforms don't use sel-logger, but nothing solid came out of
>>>>>> them and we don't have anything scheduled yet.
>>>>>>
>>>>>> It would be easy enough to have a watch on the PGOOD property, and
>>>>>> then do you what you want, like maybe turning off the thresholds.
>>>>>>
>>>>>> I heard that the d-bus sensors repository has some sort of support
>>>>>> for this, but since we don't use it I'm not sure what all that
>>>>>> entails. I think it may also force you to replace
>>>>>> phosphor-inventor-manager with entity-manager.
>>>>>
>>>>> It should force you to switch 100%, but you would at least have to run
>> both.
>>>>>
>>>>> Here's what dbus-sensors does:
>>>>>
>>>>>
>>> https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f6955827330
>>>>> 7
>>>>> a59e4b1cf86b8a6/src/Utils.cpp#L141
>>>>>
>>>>> Basically just a dbus-match that sets a "powerStatusOn" bool that
>>>>> can be queried. Depending on the sensor type thresholds don't get
>>>>> crossed if that bool is set. We also have a similar bool for bios
>>>>> post, as some sensors come up later after power on.
>>>>>
>>>>
>>>> I try to use dbus-sensors and set "powerStatusOn" bool, but still
>>>> have
>>> incorrect threshold logs during power on(S0) to power off(S5) state.
>>>> Could you help to comment on it ?
>>>>
>>>
>>> This has only been tested with x86-power-control, are you using that
>>> project for power control or something else?
>>>
>>
>> Got it. I currently use phosphor-state-manager for power control.
> 
> Hi James,
> It seems that x86-power-control need POWER_BUTTON and POWER_OUT to be connected to GPIOE0/E1 or GPIOE2/E3 for passthrough.
> If our HW design doesn't follow it, x86-power-control will not work, right ?

+ Jason, x86-power-control maintainer

I believe it just requires those names in the DTS, I don't think it 
cares what pins they are hooked to. Do you not have power buttons?


> 
>>
>>>>>>
>>>>>>> Thanks your great support in advance.
>>>>>>>
>>>>>>> *From:*openbmc
>>> <openbmc-bounces+rli11=lenovo.com@lists.ozlabs.org>
>>>>> *On
>>>>>>> Behalf Of *Ivan Li11
>>>>>>> *Sent:* Friday, October 18, 2019 5:59 PM
>>>>>>> *To:* openbmc@lists.ozlabs.org
>>>>>>> *Subject:* [External] Power-on monitor for phosphor-hwmon
>>>>>>> question
>>>>>>>
>>>>>>> Hi Team,
>>>>>>>
>>>>>>> We found that there's no power-on monitor mechanism in
>>>>> phosphor-hwmon.
>>>>>>>
>>>>>>> https://github.com/openbmc/phosphor-hwmon
>>>>>>>
>>>>>>> And it will cause incorrect threshold logs to be added to journal
>>>>>>> log by 'sel-logger' when system is in power off(S5) state.
>>>>>>>
>>>>>>> Is there any plan to implement it? Or other repository we can refer to ?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Ivan
>>>>>>>
>>>>>>