All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Mashak <mrv@mojatatu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
	jiri@resnulli.us, xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next 2/5] net sched actions: add new tc_action_ops callback
Date: Mon, 05 Mar 2018 10:46:04 -0500	[thread overview]
Message-ID: <85fu5epltv.fsf@sevai.TCC.com> (raw)
In-Reply-To: <20180305.100048.1284648153742420410.davem@davemloft.net> (David Miller's message of "Mon, 05 Mar 2018 10:00:48 -0500 (EST)")

David Miller <davem@davemloft.net> writes:

> From: Roman Mashak <mrv@mojatatu.com>
> Date: Fri,  2 Mar 2018 17:01:40 -0500
>
>> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>> index acac92a..6f3307f 100644
>> --- a/net/sched/act_api.c
>> +++ b/net/sched/act_api.c
>> @@ -136,6 +136,14 @@ static size_t tcf_action_full_attrs_size(size_t sz)
>>  		+ sz;
>>  }
>>  
>> +static size_t tcf_action_fill_size(const struct tc_action *act)
>> +{
>> +	if (act->ops->get_fill_size)
>> +		return act->ops->get_fill_size(act) +
>> +			tcf_action_shared_attrs_size(act);
>> +	return 0;
>> +}
>> +
>
> Again, a static functions with no users generates compiler warnings.

Thanks, will fix in v2.

  reply	other threads:[~2018-03-05 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 22:01 [PATCH net-next 0/5] Fix event generation for actions batch Add/Delete mode Roman Mashak
2018-03-02 22:01 ` [PATCH net-next 1/5] net sched actions: routines to calculate common TLVs size Roman Mashak
2018-03-05 15:00   ` David Miller
2018-03-05 15:45     ` Roman Mashak
2018-03-02 22:01 ` [PATCH net-next 2/5] net sched actions: add new tc_action_ops callback Roman Mashak
2018-03-05 15:00   ` David Miller
2018-03-05 15:46     ` Roman Mashak [this message]
2018-03-02 22:01 ` [PATCH net-next 3/5] net sched actions: calculate add/delete event message size Roman Mashak
2018-03-02 22:01 ` [PATCH net-next 4/5] net sched actions: implement get_fill_size routine in act_gact Roman Mashak
2018-03-02 22:01 ` [PATCH net-next 5/5] net sched actions: implement get_fill_size routine in act_police Roman Mashak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85fu5epltv.fsf@sevai.TCC.com \
    --to=mrv@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.