Re: [PATCH v5 1/4] drm/xe: Define XE_REG_IS_VALID

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 03 Apr 2024 20:54:38 -0700, Karthik Poosa wrote:
>
> Add macro to check if struct xe_reg has valid address. (Lucas, Badal).
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>  drivers/gpu/drm/xe/regs/xe_reg_defs.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_reg_defs.h b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> index c89ef2b79a3f..42078643be6b 100644
> --- a/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_reg_defs.h
> @@ -131,4 +131,6 @@ struct xe_reg_mcr {
>				 .__reg = XE_REG_INITIALIZER(r_,  ##__VA_ARGS__, .mcr = 1)	\
>				 })
>
> +#define XE_REG_IS_VALID(r)	((r.addr) ? true : false)

If this macro is needed, it can just be:

#define XE_REG_IS_VALID(r)	(r.addr)