Re: [PATCH v10 2/8] drm/xe/uapi: Introduce API for EU stall sampling

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 18 Feb 2025 11:53:52 -0800, Harish Chegondi wrote:
>
> diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c
> new file mode 100644
> index 000000000000..79af41be9c02
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_eu_stall.c
> @@ -0,0 +1,218 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2025 Intel Corporation
> + */
> +
> +#include <linux/anon_inodes.h>
> +#include <linux/fs.h>
> +#include <linux/poll.h>
> +#include <linux/types.h>
> +
> +#include <uapi/drm/xe_drm.h>
> +
> +#include "xe_device.h"
> +#include "xe_eu_stall.h"
> +#include "xe_gt_printk.h"
> +#include "xe_gt_topology.h"
> +#include "xe_macros.h"
> +#include "xe_observation.h"
> +
> +/**
> + * struct eu_stall_open_properties - EU stall sampling properties received
> + *				     from user space at open.
> + * @sampling_rate_mult: EU stall sampling rate multiplier.
> + *			HW will sample every (sampling_rate_mult x 251) cycles.
> + * @wait_num_reports: Minimum number of EU stall data reports to unblock poll().
> + * @gt: GT on which EU stall data will be captured.
> + */
> +struct eu_stall_open_properties {
> +	unsigned int sampling_rate_mult;
> +	unsigned int wait_num_reports;

Did you see Jani N's mail? These need to be changed to int (for me either
int or u32 is fine). With that addressed, the rest of the patch lgtm now,
so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>