Re: [PATCH v9 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x

From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Golle <daniel@makrotopia.org>, Rob Herring <robh@kernel.org>
Cc: "Aurelien Jarno" <aurelien@aurel32.net>,
	"Olivia Mackall" <olivia@selenic.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Dragan Simic" <dsimic@manjaro.org>,
	"Uwe Kleine-König" <ukleinek@debian.org>,
	"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Francesco Dolcini" <francesco.dolcini@toradex.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x
Date: Thu, 15 Aug 2024 18:26:12 +0200	[thread overview]
Message-ID: <861871884.pAmPZ1aGmH@diego> (raw)
In-Reply-To: <CAL_JsqKG+dMJjPXrWiQ8qZ7yfpdX3R22ntKRBawYZWTaW_9GWA@mail.gmail.com>

Am Dienstag, 13. August 2024, 16:17:05 CEST schrieb Rob Herring:
> On Tue, Jul 30, 2024 at 10:11 AM Daniel Golle <daniel@makrotopia.org> wrote:
> >
> > From: Aurelien Jarno <aurelien@aurel32.net>
> >
> > Include the just added Rockchip RNG driver for RK356x SoCs and
> > enable it on RK3568.
> >
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3568.dtsi |  4 ++++
> >  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 10 ++++++++++
> >  2 files changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> > index f1be76a54ceb0..2a6ca20e607fd 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> > @@ -257,6 +257,10 @@ power-domain@RK3568_PD_PIPE {
> >         };
> >  };
> >
> > +&rng {
> > +       status = "okay";
> > +};
> > +
> >  &usb_host0_xhci {
> >         phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
> >         phy-names = "usb2-phy", "usb3-phy";
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > index 4690be841a1cd..d160a23fd4959 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > @@ -1113,6 +1113,16 @@ sdhci: mmc@fe310000 {
> >                 status = "disabled";
> >         };
> >
> > +       rng: rng@fe388000 {
> > +               compatible = "rockchip,rk3568-rng";
> > +               reg = <0x0 0xfe388000 0x0 0x4000>;
> > +               clocks = <&cru CLK_TRNG_NS>, <&cru HCLK_TRNG_NS>;
> > +               clock-names = "core", "ahb";
> > +               resets = <&cru SRST_TRNG_NS>;
> > +               reset-names = "reset";
> 
> This adds a new warning:
> 
> rng@fe388000: 'reset-names' does not match any of the regexes: 'pinctrl-[0-9]+'

I've created and sent a patch to remove the reset-names now.