From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines.
Date: Mon, 31 Jan 2011 22:04:24 -0600 [thread overview]
Message-ID: <8622079F-F404-4AEC-B180-91F573159EDD@kernel.crashing.org> (raw)
In-Reply-To: <AANLkTimqK3PDYAcmOfRZBK69VXryMAD34AUhsavKJxfg@mail.gmail.com>
On Jan 31, 2011, at 5:36 PM, Timur Tabi wrote:
> On Mon, Jan 31, 2011 at 3:08 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>
>>> @@ -588,6 +588,9 @@ typedef struct qe_immap {
>>> #elif defined(CONFIG_MPC8569)
>>> u8 muram[0x20000]; /* 0x1_0000 - 0x3_0000 Multi-user RAM */
>>> u8 res17[0x10000]; /* 0x3_0000 - 0x4_0000 */
>>> +#elif defined(CONFIG_P1021)
>>> + u8 muram[0x06000]; /* 0x1_0000 - 0x1_6000 Multi-user RAM */
>>> + u8 res17[0x1a000]; /* 0x1_6000 - 0x3_0000 */
>>> #else
>>> u8 muram[0xC000]; /* 0x110000 - 0x11C000 Multi-user RAM */
>>> u8 res17[0x24000]; /* 0x11C000 - 0x140000 */
>>
>> Can we reduce this mess with using QE_MURAM_SIZE?
>>
>> u8 muram[QE_MURAM_SIZE];
>> u8 res17[0xNNNN - QE_MURAM_SIZE];
>
> I don't think we need res17, because nothing references it. That will
> simplify it even more.
Looks like qe_immap isn't embedded anywhere so should be ok (was concerned if the struct is expected to be a given size.
- k
next prev parent reply other threads:[~2011-02-01 4:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 18:41 [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 1/6] Introduce the Tertiary Program loader Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 2/6] powerpc/85xx: add TPL support Haiying.Wang at freescale.com
2011-01-31 18:41 ` [U-Boot] [PATCH 3/6] P1021: add P1021MDS board support Haiying.Wang at freescale.com
2011-01-31 20:03 ` Wolfgang Denk
2011-01-31 20:08 ` Scott Wood
2011-01-31 20:18 ` Wolfgang Denk
2011-01-31 20:23 ` Scott Wood
2011-01-31 21:39 ` Haiying Wang
2011-01-31 22:05 ` Kumar Gala
2011-01-31 22:16 ` Wolfgang Denk
2011-01-31 22:14 ` Wolfgang Denk
2011-01-31 21:40 ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines Haiying.Wang at freescale.com
2011-01-31 20:07 ` Wolfgang Denk
2011-01-31 21:08 ` Kumar Gala
2011-01-31 23:36 ` Timur Tabi
2011-02-01 4:04 ` Kumar Gala [this message]
2011-01-31 18:41 ` [U-Boot] [PATCH 5/6] powerpc/85xx: do not initialize QE if QE's firmware is in nand flash Haiying.Wang at freescale.com
2011-01-31 20:08 ` Wolfgang Denk
2011-01-31 21:02 ` Haiying Wang
2011-01-31 21:37 ` Wolfgang Denk
2011-02-02 4:29 ` Kumar Gala
2011-01-31 18:41 ` [U-Boot] [PATCH 6/6] p1021mds: add QE and UEC support Haiying.Wang at freescale.com
2011-01-31 20:11 ` Wolfgang Denk
2011-01-31 20:50 ` Haiying Wang
2011-01-31 21:28 ` Kumar Gala
2011-02-01 3:14 ` Haiying Wang
2011-02-01 16:50 ` Scott Wood
2011-02-01 17:01 ` Haiying Wang
2011-02-01 19:15 ` Kumar Gala
2011-02-01 19:46 ` Haiying Wang
2011-02-02 4:25 ` Kumar Gala
2011-01-31 19:39 ` [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board Wolfgang Denk
2011-01-31 20:13 ` Scott Wood
2011-01-31 20:22 ` Wolfgang Denk
2011-01-31 20:31 ` Scott Wood
2011-01-31 20:39 ` Kumar Gala
2011-01-31 20:50 ` Wolfgang Denk
2011-01-31 20:50 ` Wolfgang Denk
2011-01-31 21:15 ` Scott Wood
2011-01-31 21:34 ` Wolfgang Denk
2011-01-31 22:07 ` Scott Wood
2011-01-31 22:40 ` Wolfgang Denk
2011-01-31 22:55 ` Scott Wood
2011-02-01 5:26 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8622079F-F404-4AEC-B180-91F573159EDD@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.