All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: Kalesh Singh <kaleshsingh@google.com>,
	oliver.upton@linux.dev, kvmarm@lists.linux.dev,
	qperret@google.com, smostafa@google.com,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org
Subject: Re: [PATCH] KVM: arm64: Do not size-order align pkvm_alloc_private_va_range()
Date: Fri, 11 Aug 2023 08:11:51 +0100	[thread overview]
Message-ID: <86350qgiiw.wl-maz@kernel.org> (raw)
In-Reply-To: <ZNUZ3/nJkwUp4R3D@google.com>

On Thu, 10 Aug 2023 18:09:51 +0100,
Vincent Donnefort <vdonnefort@google.com> wrote:
> 
> On Thu, Aug 10, 2023 at 09:42:54AM -0700, Kalesh Singh wrote:
> > And I assume we want the same thing for the conventional nVHE mode:
> > remove the alignment from hyp_alloc_private_va_range() into a
> > hyp_create_stack().
> 
> Ah yes, good catch, even though it'll be less of a problem for non-protected
> nVHE, it'd probably be a good thing of aligning both. Might do that in a
> separated patch though.

I'd very much like to keep the two in sync. If anything, it is far
easier to debug on standard nVHE than with protected mode, so anything
that brings the two close to each other gets my vote.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: Kalesh Singh <kaleshsingh@google.com>,
	oliver.upton@linux.dev, kvmarm@lists.linux.dev,
	qperret@google.com, smostafa@google.com,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org
Subject: Re: [PATCH] KVM: arm64: Do not size-order align pkvm_alloc_private_va_range()
Date: Fri, 11 Aug 2023 08:11:51 +0100	[thread overview]
Message-ID: <86350qgiiw.wl-maz@kernel.org> (raw)
In-Reply-To: <ZNUZ3/nJkwUp4R3D@google.com>

On Thu, 10 Aug 2023 18:09:51 +0100,
Vincent Donnefort <vdonnefort@google.com> wrote:
> 
> On Thu, Aug 10, 2023 at 09:42:54AM -0700, Kalesh Singh wrote:
> > And I assume we want the same thing for the conventional nVHE mode:
> > remove the alignment from hyp_alloc_private_va_range() into a
> > hyp_create_stack().
> 
> Ah yes, good catch, even though it'll be less of a problem for non-protected
> nVHE, it'd probably be a good thing of aligning both. Might do that in a
> separated patch though.

I'd very much like to keep the two in sync. If anything, it is far
easier to debug on standard nVHE than with protected mode, so anything
that brings the two close to each other gets my vote.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-08-11  7:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 13:34 [PATCH] KVM: arm64: Do not size-order align pkvm_alloc_private_va_range() Vincent Donnefort
2023-08-10 13:34 ` Vincent Donnefort
2023-08-10 16:42 ` Kalesh Singh
2023-08-10 16:42   ` Kalesh Singh
2023-08-10 17:09   ` Vincent Donnefort
2023-08-10 17:09     ` Vincent Donnefort
2023-08-10 17:25     ` Kalesh Singh
2023-08-10 17:25       ` Kalesh Singh
2023-08-11  7:11     ` Marc Zyngier [this message]
2023-08-11  7:11       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86350qgiiw.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kaleshsingh@google.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=oliver.upton@linux.dev \
    --cc=qperret@google.com \
    --cc=smostafa@google.com \
    --cc=vdonnefort@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.