* [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR
@ 2007-02-18 21:44 Oleg Nesterov
2007-02-19 11:37 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Oleg Nesterov @ 2007-02-18 21:44 UTC (permalink / raw)
To: Andrew Morton, Mauro Carvalho Chehab; +Cc: David Howells, linux-kernel
pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is
never used ???
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- WQ/drivers/media/video/cpia_pp.c~3_cpia_pp 2006-12-17 19:06:40.000000000 +0300
+++ WQ/drivers/media/video/cpia_pp.c 2007-02-19 00:27:41.000000000 +0300
@@ -141,7 +141,6 @@ static void cpia_pp_run_callback(struct
cam = container_of(work, struct pp_cam_entry, cb_task);
cb_func = cam->cb_func;
cb_data = cam->cb_data;
- work_release(work);
cb_func(cb_data);
}
@@ -682,7 +681,7 @@ static int cpia_pp_registerCallback(void
if(cam->port->irq != PARPORT_IRQ_NONE) {
cam->cb_func = cb;
cam->cb_data = cbdata;
- INIT_WORK_NAR(&cam->cb_task, cpia_pp_run_callback);
+ INIT_WORK(&cam->cb_task, cpia_pp_run_callback);
} else {
retval = -1;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR
2007-02-18 21:44 [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR Oleg Nesterov
@ 2007-02-19 11:37 ` David Howells
2007-02-19 11:47 ` Oleg Nesterov
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2007-02-19 11:37 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, Mauro Carvalho Chehab, linux-kernel
Oleg Nesterov <oleg@tv-sign.ru> wrote:
> pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is
> never used ???
That's a remarkably good point. Did something get deleted since I made my
modifications? Perhaps the workqueue stuff in that file should just be
deleted entirely.
Acked-By: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR
2007-02-19 11:37 ` David Howells
@ 2007-02-19 11:47 ` Oleg Nesterov
0 siblings, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2007-02-19 11:47 UTC (permalink / raw)
To: David Howells; +Cc: Andrew Morton, Mauro Carvalho Chehab, linux-kernel
On 02/19, David Howells wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> > pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is
> > never used ???
>
> That's a remarkably good point. Did something get deleted since I made my
> modifications?
At first I thought the same. But no, it looks unused as well in 2.6.18.
> Perhaps the workqueue stuff in that file should just be
> deleted entirely.
I think yes.
> Acked-By: David Howells <dhowells@redhat.com>
Thanks.
Oleg.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-19 11:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-18 21:44 [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR Oleg Nesterov
2007-02-19 11:37 ` David Howells
2007-02-19 11:47 ` Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.