From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: [PATCH v4] drm/i915: Fix recursive calls to unmap
Date: Tue, 24 Jan 2012 11:30:52 -0800 [thread overview]
Message-ID: <864nvknbir.fsf@sumi.keithp.com> (raw)
In-Reply-To: <1327360317-4885-1-git-send-email-ben@bwidawsk.net>
[-- Attachment #1.1: Type: text/plain, Size: 683 bytes --]
On Mon, 23 Jan 2012 15:11:57 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
> v3: As Keith Packard pointed out, v2 changed retirement behavior. While
> it was intentional, it wasn't related to the bugfix, and so has been
> removed. To do this, changed i915_wait_request to be a macro to assure
> old behavior is kept.
Yuck. Using a macro and creating a new name which is nearly identical to
the old name is asking for trouble. The function signature change will
ensure that all callers are caught, and so the old callers can be
updated to pass 'false'. Given that there are only half a dozen callers,
it should be easy to just fix them.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2012-01-24 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 23:11 [PATCH] drm/i915: [PATCH v4] drm/i915: Fix recursive calls to unmap Ben Widawsky
2012-01-24 19:30 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864nvknbir.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.