From: Keith Packard <keithp@keithp.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/3] drm/i915: relative_constants_mode race fix
Date: Wed, 23 Nov 2011 13:34:06 -0800 [thread overview]
Message-ID: <864nxued69.fsf@sumi.keithp.com> (raw)
In-Reply-To: <1319337685-26195-1-git-send-email-ben@bwidawsk.net>
[-- Attachment #1.1: Type: text/plain, Size: 462 bytes --]
On Sat, 22 Oct 2011 19:41:23 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> + mode != dev_priv->relative_constants_mode) {
> + if (INTEL_INFO(dev)->gen < 4)
> + return -EINVAL;
> +
> + if (INTEL_INFO(dev)->gen > 5 &&
> + mode == I915_EXEC_CONSTANTS_REL_SURFACE)
> + return -EINVAL;
You need to clean up before returning; you've allocated cliprects and an
exec buffer and also locked the mutex.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-11-23 21:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 2:41 [PATCH 1/3] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-10-23 2:41 ` [PATCH 2/3] drm/i915: Force sync command ordering (Gen6+) Ben Widawsky
2011-12-07 18:35 ` Eric Anholt
2011-12-07 18:38 ` Jesse Barnes
2011-12-07 19:58 ` Jesse Barnes
2011-12-07 20:54 ` Eric Anholt
2011-12-07 21:03 ` Jesse Barnes
2011-12-09 2:35 ` Eric Anholt
2011-12-14 21:33 ` Jesse Barnes
2011-12-15 14:50 ` Eugeni Dodonov
2011-10-23 2:41 ` [PATCH 3/3] drm/i915: extract constant offset setting Ben Widawsky
2011-10-23 20:30 ` [PATCH 1/3] drm/i915: relative_constants_mode race fix Ben Widawsky
2011-11-23 21:34 ` Keith Packard [this message]
2011-11-23 21:59 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864nxued69.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.