From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvmarm@lists.linux.dev, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH 0/2] KVM: arm64: Fix splat relating to idregs debugfs
Date: Tue, 27 Feb 2024 18:18:37 +0000 [thread overview]
Message-ID: <867cip3h4y.wl-maz@kernel.org> (raw)
In-Reply-To: <20240227094115.1723330-1-oliver.upton@linux.dev>
On Tue, 27 Feb 2024 09:41:13 +0000,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> Looks like we're calling in to debugfs w/ preemption disabled, which
> explodes when trying to take the parent inode's rwsem.
>
> This is easy enough to work around, and we can just initialize at the
> time of VM creation. No idreg values yet? Too bad, just kick an error
> back at the user. All two of them.
>
> Applies to kvmarm/next.
>
> Oliver Upton (2):
> KVM: arm64: Fail the idreg iterator if idregs aren't initialized
> KVM: arm64: Don't initialize idreg debugfs w/ preemption disabled
Thanks for tackling this!
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-02-27 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 9:41 [PATCH 0/2] KVM: arm64: Fix splat relating to idregs debugfs Oliver Upton
2024-02-27 9:41 ` [PATCH 1/2] KVM: arm64: Fail the idreg iterator if idregs aren't initialized Oliver Upton
2024-02-27 9:41 ` [PATCH 2/2] KVM: arm64: Don't initialize idreg debugfs w/ preemption disabled Oliver Upton
2024-02-27 18:18 ` Marc Zyngier [this message]
2024-02-27 19:24 ` [PATCH 0/2] KVM: arm64: Fix splat relating to idregs debugfs Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867cip3h4y.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.