All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: kvm@vger.kernel.org, andrew.jones@linux.dev,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters
Date: Mon, 12 Dec 2022 09:05:02 +0000	[thread overview]
Message-ID: <867cyxq9fl.wl-maz@kernel.org> (raw)
In-Reply-To: <Y5XBo6s9JQVY79Wu@monolith.localdoman>

Alex,

On Sun, 11 Dec 2022 11:40:39 +0000,
Alexandru Elisei <alexandru.elisei@arm.com> wrote:
> 
> A simple "hey, you're wrong here, the PMU extensions do not follow the
> principles of the ID scheme for fields in ID registers" would have
> sufficed.

This is what I did, and saved you the hassle of looking it up.

> Guess you never made a silly mistake ever, right?

It's not so much about making a silly mistake. I do that all the time.
But it is about the way you state these things, and the weight that
your reviews carry. You're a trusted reviewer, with a lot of
experience, and posting with an @arm.com address: what you say in a
public forum sticks. When you assert that the author is wrong, they
will take it at face value.

> Otherwise, good job encouraging people to help review KVM/arm64 patches ;)

What is the worse: no review? or a review that spreads confusion?
Think about it. I'm all for being nice, but I will call bullshit when
I see it asserted by people with a certain level of authority.

And I've long made up my mind about the state of the KVM/arm64 review
process -- reviews rarely come from people who have volunteered to do
so, but instead from those who have either a vested interest in it, or
an ulterior motive. Hey ho...

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: Ricardo Koller <ricarkol@google.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	andrew.jones@linux.dev, eric.auger@redhat.com,
	oliver.upton@linux.dev, reijiw@google.com
Subject: Re: [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters
Date: Mon, 12 Dec 2022 09:05:02 +0000	[thread overview]
Message-ID: <867cyxq9fl.wl-maz@kernel.org> (raw)
In-Reply-To: <Y5XBo6s9JQVY79Wu@monolith.localdoman>

Alex,

On Sun, 11 Dec 2022 11:40:39 +0000,
Alexandru Elisei <alexandru.elisei@arm.com> wrote:
> 
> A simple "hey, you're wrong here, the PMU extensions do not follow the
> principles of the ID scheme for fields in ID registers" would have
> sufficed.

This is what I did, and saved you the hassle of looking it up.

> Guess you never made a silly mistake ever, right?

It's not so much about making a silly mistake. I do that all the time.
But it is about the way you state these things, and the weight that
your reviews carry. You're a trusted reviewer, with a lot of
experience, and posting with an @arm.com address: what you say in a
public forum sticks. When you assert that the author is wrong, they
will take it at face value.

> Otherwise, good job encouraging people to help review KVM/arm64 patches ;)

What is the worse: no review? or a review that spreads confusion?
Think about it. I'm all for being nice, but I will call bullshit when
I see it asserted by people with a certain level of authority.

And I've long made up my mind about the state of the KVM/arm64 review
process -- reviews rarely come from people who have volunteered to do
so, but instead from those who have either a vested interest in it, or
an ulterior motive. Hey ho...

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-12-12  9:05 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02  4:55 [kvm-unit-tests PATCH 0/3] arm: pmu: Add support for PMUv3p5 Ricardo Koller
2022-12-02  4:55 ` Ricardo Koller
2022-12-02  4:55 ` [kvm-unit-tests PATCH 1/3] arm: pmu: Fix overflow checks for PMUv3p5 long counters Ricardo Koller
2022-12-02  4:55   ` Ricardo Koller
2022-12-09 17:47   ` Alexandru Elisei
2022-12-09 17:47     ` Alexandru Elisei
2022-12-10 11:01     ` Marc Zyngier
2022-12-10 11:01       ` Marc Zyngier
2022-12-11 11:40       ` Alexandru Elisei
2022-12-11 11:40         ` Alexandru Elisei
2022-12-12  9:05         ` Marc Zyngier [this message]
2022-12-12  9:05           ` Marc Zyngier
2022-12-12 13:56           ` Alexandru Elisei
2022-12-12 13:56             ` Alexandru Elisei
2022-12-12 21:00     ` Ricardo Koller
2022-12-12 21:00       ` Ricardo Koller
2022-12-13 12:36   ` Alexandru Elisei
2022-12-13 12:36     ` Alexandru Elisei
2022-12-13 16:21     ` Ricardo Koller
2022-12-13 16:21       ` Ricardo Koller
2022-12-13 16:43       ` Alexandru Elisei
2022-12-13 16:43         ` Alexandru Elisei
2022-12-13 18:01         ` Ricardo Koller
2022-12-13 18:01           ` Ricardo Koller
2022-12-14 10:46           ` Alexandru Elisei
2022-12-14 10:46             ` Alexandru Elisei
2022-12-14 18:07             ` Ricardo Koller
2022-12-14 18:07               ` Ricardo Koller
2022-12-02  4:55 ` [kvm-unit-tests PATCH 2/3] arm: pmu: Prepare for testing 64-bit overflows Ricardo Koller
2022-12-02  4:55   ` Ricardo Koller
2022-12-02  4:55 ` [kvm-unit-tests PATCH 3/3] arm: pmu: Add tests for " Ricardo Koller
2022-12-02  4:55   ` Ricardo Koller
2022-12-13 17:03   ` Alexandru Elisei
2022-12-13 17:03     ` Alexandru Elisei
2022-12-13 18:04     ` Ricardo Koller
2022-12-13 18:04       ` Ricardo Koller
2022-12-14 10:45       ` Alexandru Elisei
2022-12-14 10:45         ` Alexandru Elisei
2022-12-14 18:31         ` Ricardo Koller
2022-12-14 18:31           ` Ricardo Koller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867cyxq9fl.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.