All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvmarm@lists.linux.dev, pbonzini@redhat.com,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: arm64 build failure on kvm/next
Date: Tue, 04 Oct 2022 23:32:57 +0100	[thread overview]
Message-ID: <867d1f8bja.wl-maz@kernel.org> (raw)
In-Reply-To: <YzyfcIyudmSzTKx/@google.com>

On Tue, 04 Oct 2022 22:02:40 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> Hey Paolo,
> 
> Just wanted to give you a heads up about a build failure on kvm/next.
> Marc pulled some of the sysreg refactoring updates from core arm64 to
> resolve a conflict, which resulted in:
> 
> drivers/perf/arm_spe_pmu.c:677:7: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_8_2'
>         case ID_AA64DFR0_PMSVER_8_2:
>              ^
> drivers/perf/arm_spe_pmu.c:679:7: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_8_3'
>         case ID_AA64DFR0_PMSVER_8_3:
>              ^
> drivers/perf/arm_spe_pmu.c:961:10: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_SHIFT'
>                                                    ID_AA64DFR0_PMSVER_SHIFT);
> 
> The fix has since gone in on the arm64 side [1], in case you want to
> mention in your pull request.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/sysreg&id=db74cd6337d2691ea932e36b84683090f0712ec1

Also worth noting that the SPE driver is not part of defconfig, which
is probably why it wasn't spotted the first place. Anyway, odds are
that the arm64 pull-request will get in before the KVM one, making
this pretty much invisible...

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: pbonzini@redhat.com, seanjc@google.com, kvm@vger.kernel.org,
	kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu
Subject: Re: arm64 build failure on kvm/next
Date: Tue, 04 Oct 2022 23:32:57 +0100	[thread overview]
Message-ID: <867d1f8bja.wl-maz@kernel.org> (raw)
Message-ID: <20221004223257.5SJc1vJY8gKMiM83Rodmc6HvbzvWmpq6i28KVtmS87o@z> (raw)
In-Reply-To: <YzyfcIyudmSzTKx/@google.com>

On Tue, 04 Oct 2022 22:02:40 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> Hey Paolo,
> 
> Just wanted to give you a heads up about a build failure on kvm/next.
> Marc pulled some of the sysreg refactoring updates from core arm64 to
> resolve a conflict, which resulted in:
> 
> drivers/perf/arm_spe_pmu.c:677:7: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_8_2'
>         case ID_AA64DFR0_PMSVER_8_2:
>              ^
> drivers/perf/arm_spe_pmu.c:679:7: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_8_3'
>         case ID_AA64DFR0_PMSVER_8_3:
>              ^
> drivers/perf/arm_spe_pmu.c:961:10: error: use of undeclared identifier 'ID_AA64DFR0_PMSVER_SHIFT'
>                                                    ID_AA64DFR0_PMSVER_SHIFT);
> 
> The fix has since gone in on the arm64 side [1], in case you want to
> mention in your pull request.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/sysreg&id=db74cd6337d2691ea932e36b84683090f0712ec1

Also worth noting that the SPE driver is not part of defconfig, which
is probably why it wasn't spotted the first place. Anyway, odds are
that the arm64 pull-request will get in before the KVM one, making
this pretty much invisible...

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-10-04 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 21:02 arm64 build failure on kvm/next Oliver Upton
2022-10-04 21:02 ` Oliver Upton
2022-10-04 22:32 ` Marc Zyngier [this message]
2022-10-04 22:32   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867d1f8bja.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=kvmarm@lists.linux.dev \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.