All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Vincent Donnefort <vdonnefort@google.com>,
	oliver.upton@linux.dev, kvmarm@lists.linux.dev,
	qperret@google.com, smostafa@google.com,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Remove size-order align in the nVHE hyp private VA range
Date: Sat, 26 Aug 2023 12:00:46 +0100	[thread overview]
Message-ID: <868r9yf4pt.wl-maz@kernel.org> (raw)
In-Reply-To: <CAC_TJvcwWRSs-YcP-_awLn2VU9m-AT8HzSq+aKHvSPkpRw5=OA@mail.gmail.com>

Hey Kalesh,

On Fri, 11 Aug 2023 22:55:11 +0100,
Kalesh Singh <kaleshsingh@google.com> wrote:
> 
> On Fri, Aug 11, 2023 at 4:20 AM Vincent Donnefort <vdonnefort@google.com> wrote:
> >
> > commit f922c13e778d ("KVM: arm64: Introduce
> > pkvm_alloc_private_va_range()") and commit 92abe0f81e13 ("KVM: arm64:
> > Introduce hyp_alloc_private_va_range()") added an alignment for the
> > start address of any allocation into the nVHE hypervisor private VA
> > range.

[...]

>
> Otherwise lgtm, Reviewed-by: Kalesh Singh <kaleshsingh@google.com>

Thanks for taking the time to review this.

Just a small nit: in the future, can you make sure your tags appear on
a separate line? This allows tools like 'b4' to automatically collect
them. It's not a huge deal, but I'd like to make sure to get the
credit you deserve.

Thanks again,

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Vincent Donnefort <vdonnefort@google.com>,
	oliver.upton@linux.dev, kvmarm@lists.linux.dev,
	qperret@google.com, smostafa@google.com,
	linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	will@kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Remove size-order align in the nVHE hyp private VA range
Date: Sat, 26 Aug 2023 12:00:46 +0100	[thread overview]
Message-ID: <868r9yf4pt.wl-maz@kernel.org> (raw)
In-Reply-To: <CAC_TJvcwWRSs-YcP-_awLn2VU9m-AT8HzSq+aKHvSPkpRw5=OA@mail.gmail.com>

Hey Kalesh,

On Fri, 11 Aug 2023 22:55:11 +0100,
Kalesh Singh <kaleshsingh@google.com> wrote:
> 
> On Fri, Aug 11, 2023 at 4:20 AM Vincent Donnefort <vdonnefort@google.com> wrote:
> >
> > commit f922c13e778d ("KVM: arm64: Introduce
> > pkvm_alloc_private_va_range()") and commit 92abe0f81e13 ("KVM: arm64:
> > Introduce hyp_alloc_private_va_range()") added an alignment for the
> > start address of any allocation into the nVHE hypervisor private VA
> > range.

[...]

>
> Otherwise lgtm, Reviewed-by: Kalesh Singh <kaleshsingh@google.com>

Thanks for taking the time to review this.

Just a small nit: in the future, can you make sure your tags appear on
a separate line? This allows tools like 'b4' to automatically collect
them. It's not a huge deal, but I'd like to make sure to get the
credit you deserve.

Thanks again,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-08-26 11:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230828121652eucas1p11cc5921bd55c7e90f83d1938a358237f@eucas1p1.samsung.com>
2023-08-11 11:20 ` [PATCH v2] KVM: arm64: Remove size-order align in the nVHE hyp private VA range Vincent Donnefort
2023-08-11 11:20   ` Vincent Donnefort
2023-08-11 21:55   ` Kalesh Singh
2023-08-11 21:55     ` Kalesh Singh
2023-08-14  7:40     ` Vincent Donnefort
2023-08-14  7:40       ` Vincent Donnefort
2023-08-26 11:00     ` Marc Zyngier [this message]
2023-08-26 11:00       ` Marc Zyngier
2023-08-26 13:02   ` Marc Zyngier
2023-08-26 13:02     ` Marc Zyngier
2023-08-28 12:16   ` Marek Szyprowski
2023-08-28 12:16     ` Marek Szyprowski
2023-08-28 13:19     ` Marc Zyngier
2023-08-28 13:19       ` Marc Zyngier
2023-08-28 13:43       ` Marek Szyprowski
2023-08-28 13:43         ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r9yf4pt.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=kaleshsingh@google.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=oliver.upton@linux.dev \
    --cc=qperret@google.com \
    --cc=smostafa@google.com \
    --cc=vdonnefort@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.