All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Peter Guo <peter.guo@bayhubtech.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bill Pemberton <wfp5p@virginia.edu>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Samuel Guan <samuel.guan@bayhubtech.com>,
	Xiaoguang Yu <xiaoguang.yu@bayhubtech.com>,
	Shirley Her <shirley.her@bayhubtech.com>,
	Yuxiang Wan <yuxiang.wan@bayhubtech.com>,
	Adam Lee <adam.lee@canonical.com>
Subject: Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host
Date: Sun, 27 Oct 2013 13:02:53 +0000	[thread overview]
Message-ID: <868uxeoohu.fsf@void.printf.net> (raw)
In-Reply-To: <ba51eef0193e40df9cf25b73af6890b6@BL2PR04MB083.namprd04.prod.outlook.com> (Peter Guo's message of "Wed, 23 Oct 2013 03:49:51 +0000")

Hi Peter,

On Wed, Oct 23 2013, Peter Guo wrote:
> Do you have any comments on this patch?

It would be nice if there were fewer magic constants in the patch, and
adding another 200 lines to sdhci-pci seems to suggest that it might
be time to split it out into sdhci-pci-o2micro.c.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Peter Guo <peter.guo@bayhubtech.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bill Pemberton <wfp5p@virginia.edu>,
	"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
	"linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Samuel Guan <samuel.guan@bayhubtech.com>,
	Xiaoguang Yu <xiaoguang.yu@bayhubtech.com>,
	Shirley Her <shirley.her@bayhubtech.com>,
	Yuxiang Wan <yuxiang.wan@bayhubtech.com>,
	"Adam Lee" <adam.lee@canonical.com>
Subject: Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host
Date: Sun, 27 Oct 2013 13:02:53 +0000	[thread overview]
Message-ID: <868uxeoohu.fsf@void.printf.net> (raw)
In-Reply-To: <ba51eef0193e40df9cf25b73af6890b6@BL2PR04MB083.namprd04.prod.outlook.com> (Peter Guo's message of "Wed, 23 Oct 2013 03:49:51 +0000")

Hi Peter,

On Wed, Oct 23 2013, Peter Guo wrote:
> Do you have any comments on this patch?

It would be nice if there were fewer magic constants in the patch, and
adding another 200 lines to sdhci-pci seems to suggest that it might
be time to split it out into sdhci-pci-o2micro.c.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

  reply	other threads:[~2013-10-27 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  7:26 [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host Peter Guo
2013-10-16  8:15 ` Adam Lee
2013-10-23  3:49   ` Peter Guo
2013-10-27 13:02     ` Chris Ball [this message]
2013-10-27 13:02       ` Chris Ball
2013-10-29 10:56   ` [PATCH] mmc:sdhci fix 2 tuning issues in sdchi_exectuing_tuning Peter Guo
2013-11-06 11:14   ` Peter Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868uxeoohu.fsf@void.printf.net \
    --to=cjb@laptop.org \
    --cc=adam.lee@canonical.com \
    --cc=adrian.hunter@intel.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=peter.guo@bayhubtech.com \
    --cc=samuel.guan@bayhubtech.com \
    --cc=shirley.her@bayhubtech.com \
    --cc=wfp5p@virginia.edu \
    --cc=xiaoguang.yu@bayhubtech.com \
    --cc=yuxiang.wan@bayhubtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.