Re: [PATCH v2 2/2] KVM: arm64: Trap access to SMPRI_EL1 and TPIDR2 in VHE mode

From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	Vincent Donnefort <vdonnefort@google.com>,
	James Morse <james.morse@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] KVM: arm64: Trap access to SMPRI_EL1 and TPIDR2 in VHE mode
Date: Tue, 01 Nov 2022 19:35:59 +0000	[thread overview]
Message-ID: <86a65aeacg.wl-maz@kernel.org> (raw)
In-Reply-To: <Y2EtcQSnu5R/Frhj@sirena.org.uk>

On Tue, 01 Nov 2022 14:30:09 +0000,
Mark Brown <broonie@kernel.org> wrote:
> 
> On Tue, Nov 01, 2022 at 01:33:16PM +0000, Marc Zyngier wrote:
> > Date: Tue, 1 Nov 2022 12:19:51 +0000
> > Subject: [PATCH] KVM: arm64: Fix SMPRI_EL1/TPIDR2_EL0 trapping on VHE
> > 
> > The trapping of SMPRI_EL1 and TPIDR2_EL0 currently only really
> > work on nVHE, as only this mode uses the fine-grained trapping
> > that controls these two registers.
> > 
> > Move the trapping enable/disable code into
> > __{de,}activate_traps_common(), allowing it to be called when it
> > actually matters on VHE, and remove the flipping of EL2 control
> > for TPIDR2_EL0, which only affects the host access of this
> > register.
> > 
> > Fixes: 861262ab8627 ("KVM: arm64: Handle SME host state when running guests")
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Cc: stable@vger.kernel.org
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Reviewed-by: Mark Brown <broonie@kernel.org>

Thanks. I've now applied the first patch and this one to kvmarm/fixes.

	M.

-- 
Without deviation from the norm, progress is not possible.