From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths
Date: Sun, 09 Apr 2017 19:06:36 -0600 [thread overview]
Message-ID: <86bms5xe8z.fsf@hiro.keithp.com> (raw)
In-Reply-To: <20170402131926.gejo4wnicwwekgqk@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 869 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> I think it'd be good if we could consolidate all the lease checking into
> drm_mode_object_find (respectively __drm_mode_object_find). We'd need to
> wire up the fpriv to be able to do that, but we could upstream that patch
> right away before anything else. That should take care of most of the
> checks in this patch here.
Hrm. Without some major changes, the effect of this will be to have the
lessee see only the objects which it holds a lease on. I think that's OK
as the lessor will be doing object filtering for its clients, however
it's not what Dave and I discussed, so I just want to make him aware
that the kernel is going to be simpler than originally planned. We had
originally discussed having the lessee see the un-leased objects, but to
have them reported with different status.
--
-keith
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths
Date: Sun, 09 Apr 2017 19:06:36 -0600 [thread overview]
Message-ID: <86bms5xe8z.fsf@hiro.keithp.com> (raw)
In-Reply-To: <20170402131926.gejo4wnicwwekgqk@phenom.ffwll.local>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> I think it'd be good if we could consolidate all the lease checking into
> drm_mode_object_find (respectively __drm_mode_object_find). We'd need to
> wire up the fpriv to be able to do that, but we could upstream that patch
> right away before anything else. That should take care of most of the
> checks in this patch here.
Hrm. Without some major changes, the effect of this will be to have the
lessee see only the objects which it holds a lease on. I think that's OK
as the lessor will be doing object filtering for its clients, however
it's not what Dave and I discussed, so I just want to make him aware
that the kernel is going to be simpler than originally planned. We had
originally discussed having the lessee see the un-leased objects, but to
have them reported with different status.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-10 4:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 17:08 [PATCH 0/4] drm: Add mode resource leasing Keith Packard
2017-04-01 17:08 ` [PATCH 1/4] drm: Add new LEASE debug level Keith Packard
2017-04-01 17:08 ` [PATCH 2/4] drm: Add drm_object lease infrastructure Keith Packard
2017-04-02 13:38 ` Daniel Vetter
2017-04-02 13:38 ` Daniel Vetter
2017-04-02 16:31 ` Keith Packard
2017-04-10 5:16 ` Michel Dänzer
2017-04-10 5:16 ` Michel Dänzer
2017-04-02 17:51 ` Daniel Vetter
2017-04-02 17:51 ` Daniel Vetter
2017-04-02 19:59 ` Keith Packard
2017-04-01 17:08 ` [PATCH 3/4] drm: Check mode object lease status in all master ioctl paths Keith Packard
2017-04-02 13:19 ` Daniel Vetter
2017-04-02 13:19 ` Daniel Vetter
2017-04-02 16:37 ` Keith Packard
2017-04-03 7:49 ` Daniel Vetter
2017-04-03 7:49 ` Daniel Vetter
2017-04-10 1:06 ` Keith Packard [this message]
2017-04-10 1:06 ` Keith Packard
2017-04-01 17:08 ` [PATCH 4/4] drm: Add four ioctls for managing drm mode object leases Keith Packard
2017-04-02 13:23 ` Daniel Vetter
2017-04-02 13:23 ` Daniel Vetter
2017-04-02 16:44 ` Keith Packard
2017-04-29 6:06 ` [PATCH 0/5] drm: Add mode resource leasing [v2] Keith Packard
2017-04-29 6:06 ` Keith Packard
2017-04-29 6:06 ` [PATCH 1/5] drm: Pass struct drm_file * to __drm_mode_object_find Keith Packard
2017-04-29 6:06 ` Keith Packard
2017-04-29 6:06 ` [PATCH 2/5] drm: Add new LEASE debug level Keith Packard
2017-04-29 6:06 ` Keith Packard
2017-04-29 6:07 ` [PATCH 3/5] drm: Add drm_object lease infrastructure [v2] Keith Packard
2017-04-29 6:07 ` Keith Packard
2017-04-29 6:07 ` [PATCH 4/5] drm: Check mode object lease status in all master ioctl paths [v2] Keith Packard
2017-04-29 6:07 ` Keith Packard
2017-04-29 6:07 ` [PATCH 5/5] drm: Add three ioctls for managing drm mode object leases [v2] Keith Packard
2017-04-29 6:07 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bms5xe8z.fsf@hiro.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.