From: Chris Ball <chris@printf.net>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org,
broonie@kernel.org, linus.walleij@linaro.org, sebras@gmail.com
Subject: Re: [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils
Date: Tue, 23 Feb 2016 04:18:09 +0000 [thread overview]
Message-ID: <86bn78dpq6.fsf@void.printf.net> (raw)
In-Reply-To: <4230761e156940906a837686e1cc780f417567b7.1456194879.git.baolin.wang@spreadtrum.com> (Baolin Wang's message of "Tue, 23 Feb 2016 10:36:46 +0800")
Hi Baolin,
What is the difference between v2 and v3? It's good to include a
changelog with each new patch.
Regarding the merge, I don't think it makes sense to merge in lsmmc.c
if the entire EXT_CSD parser inside it can't be used right now.
We might as well just leave it out altogether until it's ready to
be used. I don't think there's any point in adding a lot of new
unused code just because we might want to use it later.
Does that make sense? Thanks,
- Chris.
--
Chris Ball <http://printf.net/>
next parent reply other threads:[~2016-02-23 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4230761e156940906a837686e1cc780f417567b7.1456194879.git.baolin.wang@spreadtrum.com>
2016-02-23 4:18 ` Chris Ball [this message]
2016-02-23 5:23 ` [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bn78dpq6.fsf@void.printf.net \
--to=chris@printf.net \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sebras@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.