* Re: [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils
[not found] <4230761e156940906a837686e1cc780f417567b7.1456194879.git.baolin.wang@spreadtrum.com>
@ 2016-02-23 4:18 ` Chris Ball
2016-02-23 5:23 ` Baolin Wang
0 siblings, 1 reply; 2+ messages in thread
From: Chris Ball @ 2016-02-23 4:18 UTC (permalink / raw)
To: Baolin Wang; +Cc: linux-mmc, ulf.hansson, broonie, linus.walleij, sebras
Hi Baolin,
What is the difference between v2 and v3? It's good to include a
changelog with each new patch.
Regarding the merge, I don't think it makes sense to merge in lsmmc.c
if the entire EXT_CSD parser inside it can't be used right now.
We might as well just leave it out altogether until it's ready to
be used. I don't think there's any point in adding a lot of new
unused code just because we might want to use it later.
Does that make sense? Thanks,
- Chris.
--
Chris Ball <http://printf.net/>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils
2016-02-23 4:18 ` [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils Chris Ball
@ 2016-02-23 5:23 ` Baolin Wang
0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2016-02-23 5:23 UTC (permalink / raw)
To: Chris Ball
Cc: linux-mmc, Ulf Hansson, Mark Brown, Linus Walleij,
Sebastian Rasmussen
Hi Chris,
On 23 February 2016 at 12:18, Chris Ball <chris@printf.net> wrote:
> Hi Baolin,
>
> What is the difference between v2 and v3? It's good to include a
> changelog with each new patch.
Oh, sorry. I would add a changelog in next version. This version I
changed the ext_csd read command replacing with the parser in lsmmc.c.
It is not sensible if we combine the different extcsd parse style
together.
>
> Regarding the merge, I don't think it makes sense to merge in lsmmc.c
> if the entire EXT_CSD parser inside it can't be used right now.
> We might as well just leave it out altogether until it's ready to
> be used. I don't think there's any point in adding a lot of new
> unused code just because we might want to use it later.
>
> Does that make sense? Thanks,
OK. I'll remove the EXT_CSD parser from lsmmc.c code. Thanks for your comments.
>
> - Chris.
> --
> Chris Ball <http://printf.net/>
--
Baolin.wang
Best Regards
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-23 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4230761e156940906a837686e1cc780f417567b7.1456194879.git.baolin.wang@spreadtrum.com>
2016-02-23 4:18 ` [PATCH v3] mmc-utils: Merge the lsmmc tool into mmc-utils Chris Ball
2016-02-23 5:23 ` Baolin Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.