From: Chris Ball <chris@printf.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Andrew Bresticker <abrestic@chromium.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/2] mmc: tegra: fix reporting of base clock frequency
Date: Fri, 23 May 2014 13:53:29 +0100 [thread overview]
Message-ID: <86bnuor706.fsf@void.printf.net> (raw)
In-Reply-To: <CAPDyKFqBcp7PZQ-04s02Jrqscna0UVex2DEbVPYghmRR8g9HnA@mail.gmail.com> (Ulf Hansson's message of "Fri, 23 May 2014 09:04:12 +0200")
Hi,
On Fri, May 23 2014, Ulf Hansson wrote:
> On 22 May 2014 17:55, Andrew Bresticker <abrestic@chromium.org> wrote:
>> Tegra SDHCI controllers, by default, report a base clock frequency
>> of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the
>> actual base clock frequency. This is because the clock rate is
>> configured by the clock controller, which is external to the SD/MMC
>> controller. Since the SD/MMC controller has no knowledge of how this
>> clock is configured, it will simply report the maximum frequency.
>> While the reported value can be overridden by setting BASE_CLK_FREQ in
>> VENDOR_CLOCK_CTRL on Tegra30 and later SoCs, just set CAP_CLOCK_BASE_BROKEN
>> and supply sdhci_pltfm_clk_get_max_clock(), which simply does a
>> clk_get_rate(), as the get_max_clock() callback.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> Tested-by: Stephen Warren <swarren@nvidia.com>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> Thanks Andrew!
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Chris, can you pick this up?
Thanks, pushed to mmc-next for 3.16.
- Chris.
--
Chris Ball <http://printf.net/>
WARNING: multiple messages have this Message-ID (diff)
From: chris@printf.net (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] mmc: tegra: fix reporting of base clock frequency
Date: Fri, 23 May 2014 13:53:29 +0100 [thread overview]
Message-ID: <86bnuor706.fsf@void.printf.net> (raw)
In-Reply-To: <CAPDyKFqBcp7PZQ-04s02Jrqscna0UVex2DEbVPYghmRR8g9HnA@mail.gmail.com> (Ulf Hansson's message of "Fri, 23 May 2014 09:04:12 +0200")
Hi,
On Fri, May 23 2014, Ulf Hansson wrote:
> On 22 May 2014 17:55, Andrew Bresticker <abrestic@chromium.org> wrote:
>> Tegra SDHCI controllers, by default, report a base clock frequency
>> of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the
>> actual base clock frequency. This is because the clock rate is
>> configured by the clock controller, which is external to the SD/MMC
>> controller. Since the SD/MMC controller has no knowledge of how this
>> clock is configured, it will simply report the maximum frequency.
>> While the reported value can be overridden by setting BASE_CLK_FREQ in
>> VENDOR_CLOCK_CTRL on Tegra30 and later SoCs, just set CAP_CLOCK_BASE_BROKEN
>> and supply sdhci_pltfm_clk_get_max_clock(), which simply does a
>> clk_get_rate(), as the get_max_clock() callback.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> Tested-by: Stephen Warren <swarren@nvidia.com>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> Thanks Andrew!
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Chris, can you pick this up?
Thanks, pushed to mmc-next for 3.16.
- Chris.
--
Chris Ball <http://printf.net/>
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <chris@printf.net>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Andrew Bresticker <abrestic@chromium.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-tegra\@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/2] mmc: tegra: fix reporting of base clock frequency
Date: Fri, 23 May 2014 13:53:29 +0100 [thread overview]
Message-ID: <86bnuor706.fsf@void.printf.net> (raw)
In-Reply-To: <CAPDyKFqBcp7PZQ-04s02Jrqscna0UVex2DEbVPYghmRR8g9HnA@mail.gmail.com> (Ulf Hansson's message of "Fri, 23 May 2014 09:04:12 +0200")
Hi,
On Fri, May 23 2014, Ulf Hansson wrote:
> On 22 May 2014 17:55, Andrew Bresticker <abrestic@chromium.org> wrote:
>> Tegra SDHCI controllers, by default, report a base clock frequency
>> of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the
>> actual base clock frequency. This is because the clock rate is
>> configured by the clock controller, which is external to the SD/MMC
>> controller. Since the SD/MMC controller has no knowledge of how this
>> clock is configured, it will simply report the maximum frequency.
>> While the reported value can be overridden by setting BASE_CLK_FREQ in
>> VENDOR_CLOCK_CTRL on Tegra30 and later SoCs, just set CAP_CLOCK_BASE_BROKEN
>> and supply sdhci_pltfm_clk_get_max_clock(), which simply does a
>> clk_get_rate(), as the get_max_clock() callback.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> Tested-by: Stephen Warren <swarren@nvidia.com>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> Thanks Andrew!
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Chris, can you pick this up?
Thanks, pushed to mmc-next for 3.16.
- Chris.
--
Chris Ball <http://printf.net/>
next prev parent reply other threads:[~2014-05-23 12:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 15:55 [PATCH v3 1/2] mmc: tegra: disable UHS modes Andrew Bresticker
2014-05-22 15:55 ` Andrew Bresticker
2014-05-22 15:55 ` Andrew Bresticker
2014-05-22 15:55 ` [PATCH v3 2/2] mmc: tegra: fix reporting of base clock frequency Andrew Bresticker
2014-05-22 15:55 ` Andrew Bresticker
[not found] ` <1400774136-12396-2-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-23 7:04 ` Ulf Hansson
2014-05-23 7:04 ` Ulf Hansson
2014-05-23 7:04 ` Ulf Hansson
2014-05-23 12:53 ` Chris Ball [this message]
2014-05-23 12:53 ` Chris Ball
2014-05-23 12:53 ` Chris Ball
[not found] ` <1400774136-12396-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-05-23 7:03 ` [PATCH v3 1/2] mmc: tegra: disable UHS modes Ulf Hansson
2014-05-23 7:03 ` Ulf Hansson
2014-05-23 7:03 ` Ulf Hansson
2014-05-23 12:52 ` Chris Ball
2014-05-23 12:52 ` Chris Ball
2014-05-23 12:52 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bnuor706.fsf@void.printf.net \
--to=chris@printf.net \
--cc=abrestic@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.