[PATCH] drm/i915: correct lock type in destroy

* [PATCH] drm/i915: correct lock type in destroy
@ 2012-01-23 23:30 Ben Widawsky
  2012-01-24  5:20 ` Keith Packard
  2012-01-26 10:31 ` Daniel Vetter
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Widawsky @ 2012-01-23 23:30 UTC (permalink / raw)
  To: intel-gfx; +Cc: Ben Widawsky

This is only relevant when using module unloading, and really only helps
get rid of a probably benign warning.

I can't remember if I sent this out already, but it's not turning up in
any of my searches.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
 drivers/gpu/drm/i915/i915_irq.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 65ee789..d71c0a5 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1016,11 +1016,12 @@ void i915_destroy_error_state(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct drm_i915_error_state *error;
+	unsigned long flags;
 
-	spin_lock(&dev_priv->error_lock);
+	spin_lock_irqsave(&dev_priv->error_lock, flags);
 	error = dev_priv->first_error;
 	dev_priv->first_error = NULL;
-	spin_unlock(&dev_priv->error_lock);
+	spin_unlock_irqrestore(&dev_priv->error_lock, flags);
 
 	if (error)
 		i915_error_state_free(dev, error);
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread