[PATCH v4 0/2] irqchip: Kconfig: Add module support for TI inta/intr

[PATCH v4 0/2] irqchip: Kconfig: Add module support for TI inta/intr

[Guillaume La Roque]

Added module support for TI interrupt aggregator and interrupt router
drivers. Default value for both drivers is ARCH_K3 and the interrupt
aggregator depends on ARCH_K3 as it contains 64 bit only ops.
Tested allmodconfig builds with ARCH=arm and ARCH=arm64.

Changes in v4:
- Rework commit message and title
- Add depends on in Kconfig frivers
- Link to v3: https://lore.kernel.org/r/20241016-timodules-v3-0-fa71091ade98@baylibre.com

Changes in v3:
- Add MODULE_LICENSE in drivers

Changes in v2:
- Added depends on ARCH_K3 for the interrupt aggregator driver as it
  uses
64 bit ops

Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
Nicolas Frayer (2):
      irqchip/ti-sci-intr: add module build support
      irqchip/ti-sci-inta : Add module build support

 arch/arm64/Kconfig.platforms      | 2 --
 drivers/irqchip/Kconfig           | 6 ++++--
 drivers/irqchip/irq-ti-sci-inta.c | 1 +
 drivers/irqchip/irq-ti-sci-intr.c | 1 +
 4 files changed, 6 insertions(+), 4 deletions(-)
---
base-commit: 8faabc041a001140564f718dabe37753e88b37fa
change-id: 20241016-timodules-174770215dd8

Best regards,
-- 
Guillaume La Roque <glaroque@baylibre.com>

[PATCH v4 1/2] irqchip/ti-sci-intr: add module build support

[Guillaume La Roque]

From: Nicolas Frayer <nfrayer@baylibre.com>

Add module build support in Kconfig for the TI SCI interrupt router
driver.This driver depends on TI sci firmware driver which are aready
support module build.

Add MODULE_LICENSE which is mandatory to support module build.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
 arch/arm64/Kconfig.platforms      | 1 -
 drivers/irqchip/Kconfig           | 3 ++-
 drivers/irqchip/irq-ti-sci-intr.c | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 370a9d2b6919..eda592ac9c8d 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -135,7 +135,6 @@ config ARCH_K3
 	select SOC_TI
 	select TI_MESSAGE_MANAGER
 	select TI_SCI_PROTOCOL
-	select TI_SCI_INTR_IRQCHIP
 	select TI_SCI_INTA_IRQCHIP
 	select TI_K3_SOCINFO
 	help
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 9bee02db1643..1099691c45d5 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -534,8 +534,9 @@ config LS1X_IRQ
 	  Support for the Loongson-1 platform Interrupt Controller.
 
 config TI_SCI_INTR_IRQCHIP
-	bool
+	tristate "TI SCI INTR Interrupt Controller"
 	depends on TI_SCI_PROTOCOL
+	depends on ARCH_K3 || COMPILE_TEST
 	select IRQ_DOMAIN_HIERARCHY
 	help
 	  This enables the irqchip driver support for K3 Interrupt router
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
index c027cd9e4a69..b49a73106c69 100644
--- a/drivers/irqchip/irq-ti-sci-intr.c
+++ b/drivers/irqchip/irq-ti-sci-intr.c
@@ -303,3 +303,4 @@ module_platform_driver(ti_sci_intr_irq_domain_driver);
 
 MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
 MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
+MODULE_LICENSE("GPL");

-- 
2.34.1

[PATCH v4 2/2] irqchip/ti-sci-inta : Add module build support

[Guillaume La Roque]

From: Nicolas Frayer <nfrayer@baylibre.com>

Add module build support in Kconfig for the TI SCI interrupt aggregator
driver. The driver's default build is built-in and it also depends on
ARCH_K3 as the driver uses some 64 bit ops and should only be built
for 64 bit platforms.

Add MODULE_LICENSE which is mandatory to support module build.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
---
 arch/arm64/Kconfig.platforms      | 1 -
 drivers/irqchip/Kconfig           | 3 ++-
 drivers/irqchip/irq-ti-sci-inta.c | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index eda592ac9c8d..02007256709e 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -135,7 +135,6 @@ config ARCH_K3
 	select SOC_TI
 	select TI_MESSAGE_MANAGER
 	select TI_SCI_PROTOCOL
-	select TI_SCI_INTA_IRQCHIP
 	select TI_K3_SOCINFO
 	help
 	  This enables support for Texas Instruments' K3 multicore SoC
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 1099691c45d5..be063bfb50c4 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -545,8 +545,9 @@ config TI_SCI_INTR_IRQCHIP
 	  TI System Controller, say Y here. Otherwise, say N.
 
 config TI_SCI_INTA_IRQCHIP
-	bool
+	tristate "TI SCI INTA Interrupt Controller"
 	depends on TI_SCI_PROTOCOL
+	depends on ARCH_K3 || (COMPILE_TEST && ARM64)
 	select IRQ_DOMAIN_HIERARCHY
 	select TI_SCI_INTA_MSI_DOMAIN
 	help
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index b83f5cbab123..a887efba262c 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -743,3 +743,4 @@ module_platform_driver(ti_sci_inta_irq_domain_driver);
 
 MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ti.com>");
 MODULE_DESCRIPTION("K3 Interrupt Aggregator driver over TI SCI protocol");
+MODULE_LICENSE("GPL");

-- 
2.34.1

Re: [PATCH v4 0/2] irqchip: Kconfig: Add module support for TI inta/intr

[Nishanth Menon]

On 20:36-20241224, Guillaume La Roque wrote:
> Added module support for TI interrupt aggregator and interrupt router
> drivers. Default value for both drivers is ARCH_K3 and the interrupt
> aggregator depends on ARCH_K3 as it contains 64 bit only ops.
> Tested allmodconfig builds with ARCH=arm and ARCH=arm64.
> 
> Changes in v4:
> - Rework commit message and title
> - Add depends on in Kconfig frivers
> - Link to v3: https://lore.kernel.org/r/20241016-timodules-v3-0-fa71091ade98@baylibre.com
> 
> Changes in v3:
> - Add MODULE_LICENSE in drivers
> 
> Changes in v2:
> - Added depends on ARCH_K3 for the interrupt aggregator driver as it
>   uses
> 64 bit ops
> 
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> Nicolas Frayer (2):
>       irqchip/ti-sci-intr: add module build support
>       irqchip/ti-sci-inta : Add module build support
> 
>  arch/arm64/Kconfig.platforms      | 2 --
>  drivers/irqchip/Kconfig           | 6 ++++--
>  drivers/irqchip/irq-ti-sci-inta.c | 1 +
>  drivers/irqchip/irq-ti-sci-intr.c | 1 +
>  4 files changed, 6 insertions(+), 4 deletions(-)
> ---
> base-commit: 8faabc041a001140564f718dabe37753e88b37fa
> change-id: 20241016-timodules-174770215dd8
> 
> Best regards,
> -- 
> Guillaume La Roque <glaroque@baylibre.com>
> 

Reviewed-by: Nishanth Menon <nm@ti.com>

Marc, Can this go via your tree?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v4 0/2] irqchip: Kconfig: Add module support for TI inta/intr

[Marc Zyngier]

On Thu, 02 Jan 2025 12:44:13 +0000,
Nishanth Menon <nm@ti.com> wrote:
> 
> On 20:36-20241224, Guillaume La Roque wrote:
> > Added module support for TI interrupt aggregator and interrupt router
> > drivers. Default value for both drivers is ARCH_K3 and the interrupt
> > aggregator depends on ARCH_K3 as it contains 64 bit only ops.
> > Tested allmodconfig builds with ARCH=arm and ARCH=arm64.
> > 
> > Changes in v4:
> > - Rework commit message and title
> > - Add depends on in Kconfig frivers
> > - Link to v3: https://lore.kernel.org/r/20241016-timodules-v3-0-fa71091ade98@baylibre.com
> > 
> > Changes in v3:
> > - Add MODULE_LICENSE in drivers
> > 
> > Changes in v2:
> > - Added depends on ARCH_K3 for the interrupt aggregator driver as it
> >   uses
> > 64 bit ops
> > 
> > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> > ---
> > Nicolas Frayer (2):
> >       irqchip/ti-sci-intr: add module build support
> >       irqchip/ti-sci-inta : Add module build support
> > 
> >  arch/arm64/Kconfig.platforms      | 2 --
> >  drivers/irqchip/Kconfig           | 6 ++++--
> >  drivers/irqchip/irq-ti-sci-inta.c | 1 +
> >  drivers/irqchip/irq-ti-sci-intr.c | 1 +
> >  4 files changed, 6 insertions(+), 4 deletions(-)
> > ---
> > base-commit: 8faabc041a001140564f718dabe37753e88b37fa
> > change-id: 20241016-timodules-174770215dd8
> > 
> > Best regards,
> > -- 
> > Guillaume La Roque <glaroque@baylibre.com>
> > 
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>
> 
> Marc, Can this go via your tree?

I'm only looking after the ARM GICs these days, and not anything else.
Hopefully Thomas will look into it.

THanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH v4 0/2] irqchip: Kconfig: Add module support for TI inta/intr

[Nishanth Menon]

On 13:09-20250102, Marc Zyngier wrote:
> On Thu, 02 Jan 2025 12:44:13 +0000,
> Nishanth Menon <nm@ti.com> wrote:
> > 
> > On 20:36-20241224, Guillaume La Roque wrote:
> > > Added module support for TI interrupt aggregator and interrupt router
> > > drivers. Default value for both drivers is ARCH_K3 and the interrupt
> > > aggregator depends on ARCH_K3 as it contains 64 bit only ops.
> > > Tested allmodconfig builds with ARCH=arm and ARCH=arm64.
> > > 
> > > Changes in v4:
> > > - Rework commit message and title
> > > - Add depends on in Kconfig frivers
> > > - Link to v3: https://lore.kernel.org/r/20241016-timodules-v3-0-fa71091ade98@baylibre.com
> > > 
> > > Changes in v3:
> > > - Add MODULE_LICENSE in drivers
> > > 
> > > Changes in v2:
> > > - Added depends on ARCH_K3 for the interrupt aggregator driver as it
> > >   uses
> > > 64 bit ops
> > > 
> > > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> > > ---
> > > Nicolas Frayer (2):
> > >       irqchip/ti-sci-intr: add module build support
> > >       irqchip/ti-sci-inta : Add module build support
> > > 
> > >  arch/arm64/Kconfig.platforms      | 2 --
> > >  drivers/irqchip/Kconfig           | 6 ++++--
> > >  drivers/irqchip/irq-ti-sci-inta.c | 1 +
> > >  drivers/irqchip/irq-ti-sci-intr.c | 1 +
> > >  4 files changed, 6 insertions(+), 4 deletions(-)
> > > ---
> > > base-commit: 8faabc041a001140564f718dabe37753e88b37fa
> > > change-id: 20241016-timodules-174770215dd8
> > > 
> > > Best regards,
> > > -- 
> > > Guillaume La Roque <glaroque@baylibre.com>
> > > 
> > 
> > Reviewed-by: Nishanth Menon <nm@ti.com>
> > 
> > Marc, Can this go via your tree?
> 
> I'm only looking after the ARM GICs these days, and not anything else.
> Hopefully Thomas will look into it.

Thanks Marc.

Thomas, would like to know if you'd pick this up, else, I can take
this series via my tree and send via SoC maintainers, since I am
marked as the maintainer for the files.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

[tip: irq/core] irqchip/ti-sci-inta : Add module build support

[tip-bot2 for Nicolas Frayer]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     b8b26ae398c4577893a4c43195dba0e75af6e33f
Gitweb:        https://git.kernel.org/tip/b8b26ae398c4577893a4c43195dba0e75af6e33f
Author:        Nicolas Frayer <nfrayer@baylibre.com>
AuthorDate:    Tue, 24 Dec 2024 20:36:43 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 15 Jan 2025 09:54:29 +01:00

irqchip/ti-sci-inta : Add module build support

Add module build support in Kconfig for the TI SCI interrupt aggregator
driver. The driver's default build is built-in and it also depends on
ARCH_K3 as the driver uses some 64 bit ops and should only be built for
64-bit platforms.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Nishanth Menon <nm@ti.com>
Link: https://lore.kernel.org/all/20241224-timodules-v4-2-c5e010f58e2c@baylibre.com
---
 arch/arm64/Kconfig.platforms      | 1 -
 drivers/irqchip/Kconfig           | 3 ++-
 drivers/irqchip/irq-ti-sci-inta.c | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index eda592a..0200725 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -135,7 +135,6 @@ config ARCH_K3
 	select SOC_TI
 	select TI_MESSAGE_MANAGER
 	select TI_SCI_PROTOCOL
-	select TI_SCI_INTA_IRQCHIP
 	select TI_K3_SOCINFO
 	help
 	  This enables support for Texas Instruments' K3 multicore SoC
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 6f1b7d2..fb22f27 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -545,8 +545,9 @@ config TI_SCI_INTR_IRQCHIP
 	  TI System Controller, say Y here. Otherwise, say N.
 
 config TI_SCI_INTA_IRQCHIP
-	bool
+	tristate "TI SCI INTA Interrupt Controller"
 	depends on TI_SCI_PROTOCOL
+	depends on ARCH_K3 || (COMPILE_TEST && ARM64)
 	select IRQ_DOMAIN_HIERARCHY
 	select TI_SCI_INTA_MSI_DOMAIN
 	help
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
index b83f5cb..a887efb 100644
--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -743,3 +743,4 @@ module_platform_driver(ti_sci_inta_irq_domain_driver);
 
 MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ti.com>");
 MODULE_DESCRIPTION("K3 Interrupt Aggregator driver over TI SCI protocol");
+MODULE_LICENSE("GPL");

[tip: irq/core] irqchip/ti-sci-intr: Add module build support

[tip-bot2 for Nicolas Frayer]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     2d95ffaecbc2a29cf4a0fa8e63ce99ded7184991
Gitweb:        https://git.kernel.org/tip/2d95ffaecbc2a29cf4a0fa8e63ce99ded7184991
Author:        Nicolas Frayer <nfrayer@baylibre.com>
AuthorDate:    Tue, 24 Dec 2024 20:36:42 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 15 Jan 2025 09:54:29 +01:00

irqchip/ti-sci-intr: Add module build support

Add module build support in Kconfig for the TI SCI interrupt router
driver. This driver depends on the TI sci firmware driver which aready
supports module build.

Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Nishanth Menon <nm@ti.com>
Link: https://lore.kernel.org/all/20241224-timodules-v4-1-c5e010f58e2c@baylibre.com
---
 arch/arm64/Kconfig.platforms      | 1 -
 drivers/irqchip/Kconfig           | 3 ++-
 drivers/irqchip/irq-ti-sci-intr.c | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 370a9d2..eda592a 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -135,7 +135,6 @@ config ARCH_K3
 	select SOC_TI
 	select TI_MESSAGE_MANAGER
 	select TI_SCI_PROTOCOL
-	select TI_SCI_INTR_IRQCHIP
 	select TI_SCI_INTA_IRQCHIP
 	select TI_K3_SOCINFO
 	help
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 55d7122..6f1b7d2 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -534,8 +534,9 @@ config LS1X_IRQ
 	  Support for the Loongson-1 platform Interrupt Controller.
 
 config TI_SCI_INTR_IRQCHIP
-	bool
+	tristate "TI SCI INTR Interrupt Controller"
 	depends on TI_SCI_PROTOCOL
+	depends on ARCH_K3 || COMPILE_TEST
 	select IRQ_DOMAIN_HIERARCHY
 	help
 	  This enables the irqchip driver support for K3 Interrupt router
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
index c027cd9..b49a731 100644
--- a/drivers/irqchip/irq-ti-sci-intr.c
+++ b/drivers/irqchip/irq-ti-sci-intr.c
@@ -303,3 +303,4 @@ module_platform_driver(ti_sci_intr_irq_domain_driver);
 
 MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
 MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
+MODULE_LICENSE("GPL");