From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: properly prefault for pread/pwrite
Date: Fri, 18 Nov 2011 09:42:42 -0800 [thread overview]
Message-ID: <86d3cpminh.fsf@sumi.keithp.com> (raw)
In-Reply-To: <CAKMK7uG9GUg=9aFyVxFBso=uW3Dg_qzaiekMUMKytRQ5iNTnXQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1119 bytes --]
On Fri, 18 Nov 2011 10:12:38 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> We want to prefault the last byte if the pfn of the last prefault
> address doesn't match the pfn of the last byte of the userspace
> address range. Only happens when userspace hands in badly aligned
> address, not every time. I've rechecked and I think the code actually
> does what I want it to do.
Sorry, I was confused by PAGE_MASK (again); assumed it was 0xfff instead
of ~0xfff.
> Chris was despised at the lack of beauty of the code and I agree. Due
> to the ppgtt trip to Poland I haven't gotten around to do it actually.
> Actually I've just noticed that this is might be the old pwrite/pread
> series (mail here still sucks). The new one fixes up the prefault
> helpers in pagemap.h (instead of reinventing the wheel for i915.ko),
> but they have the same issue of profound ugliness.
Right, that was in a different mail thread and is still awaiting
cleanups it seems. Sounds like you're having adventures in Poland at
least. I'll pend this until you've gotten it finished and ready to
merge.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2011-11-18 17:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 9:57 [PATCH 1/2] io-mapping: ensure io_mapping_map_atomic _is_ atomic Daniel Vetter
2011-09-28 9:57 ` [PATCH 2/2] drm/i915: properly prefault for pread/pwrite Daniel Vetter
2011-09-28 11:24 ` Chris Wilson
2011-10-23 10:18 ` Daniel Vetter
2011-10-23 10:19 ` Daniel Vetter
2011-10-23 19:23 ` Keith Packard
2011-10-23 22:11 ` Daniel Vetter
2011-11-03 21:06 ` [Intel-gfx] " Keith Packard
2011-11-03 21:06 ` Keith Packard
2011-11-03 22:10 ` [Intel-gfx] " Daniel Vetter
2011-11-03 22:10 ` Daniel Vetter
2011-11-17 20:52 ` Keith Packard
2011-11-18 9:12 ` Daniel Vetter
2011-11-18 17:42 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d3cpminh.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.