From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Yishai Hadas <yishaih@mellanox.com>,
Shaker Daibes <shakerd@mellanox.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net/mlx4_en: fix a condition
Date: Sun, 05 Feb 2017 08:26:54 +0000 [thread overview]
Message-ID: <86df2437-317f-aaa3-fd33-406b3db30da3@gmail.com> (raw)
In-Reply-To: <20170203095459.GA5704@mwanda>
On 03/02/2017 11:54 AM, Dan Carpenter wrote:
> There is a "||" vs "|" typo here so we test 0x1 instead of 0x6.
>
> Fixes: 1f8176f7352a ("net/mlx4_en: Check the enabling pptx/pprx flags in SET_PORT wrapper flow")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
> index 5053c949148f..4e36e287d605 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
> @@ -1395,7 +1395,7 @@ static int mlx4_common_set_port(struct mlx4_dev *dev, int slave, u32 in_mod,
> gen_context);
>
> if (gen_context->flags &
> - (MLX4_FLAG_V_PPRX_MASK || MLX4_FLAG_V_PPTX_MASK))
> + (MLX4_FLAG_V_PPRX_MASK | MLX4_FLAG_V_PPTX_MASK))
> mlx4_en_set_port_global_pause(dev, slave,
> gen_context);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks Dan.
WARNING: multiple messages have this Message-ID (diff)
From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Yishai Hadas <yishaih@mellanox.com>,
Shaker Daibes <shakerd@mellanox.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net/mlx4_en: fix a condition
Date: Sun, 5 Feb 2017 10:26:54 +0200 [thread overview]
Message-ID: <86df2437-317f-aaa3-fd33-406b3db30da3@gmail.com> (raw)
In-Reply-To: <20170203095459.GA5704@mwanda>
On 03/02/2017 11:54 AM, Dan Carpenter wrote:
> There is a "||" vs "|" typo here so we test 0x1 instead of 0x6.
>
> Fixes: 1f8176f7352a ("net/mlx4_en: Check the enabling pptx/pprx flags in SET_PORT wrapper flow")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
> index 5053c949148f..4e36e287d605 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
> @@ -1395,7 +1395,7 @@ static int mlx4_common_set_port(struct mlx4_dev *dev, int slave, u32 in_mod,
> gen_context);
>
> if (gen_context->flags &
> - (MLX4_FLAG_V_PPRX_MASK || MLX4_FLAG_V_PPTX_MASK))
> + (MLX4_FLAG_V_PPRX_MASK | MLX4_FLAG_V_PPTX_MASK))
> mlx4_en_set_port_global_pause(dev, slave,
> gen_context);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks Dan.
next prev parent reply other threads:[~2017-02-05 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:54 [patch net-next] net/mlx4_en: fix a condition Dan Carpenter
2017-02-03 9:54 ` Dan Carpenter
2017-02-05 8:26 ` Tariq Toukan [this message]
2017-02-05 8:26 ` Tariq Toukan
2017-02-06 17:01 ` David Miller
2017-02-06 17:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86df2437-317f-aaa3-fd33-406b3db30da3@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shakerd@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.