* [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
@ 2017-10-25 7:23 ` Antoine Tenart
0 siblings, 0 replies; 7+ messages in thread
From: Antoine Tenart @ 2017-10-25 7:23 UTC (permalink / raw)
To: tglx, marc.zyngier, jason, gregory.clement, andrew,
sebastian.hesselbarth, thomas.petazzoni
Cc: Antoine Tenart, miquel.raynal, nadavh, linux-kernel,
linux-arm-kernel
A spin lock is used in the irq-mvebu-gicp driver, but it is never
initialized. This patch adds the missing spin_lock_init() call in the
driver's probe function.
Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
drivers/irqchip/irq-mvebu-gicp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
index b283fc90be1e..17a4a7b6cdbb 100644
--- a/drivers/irqchip/irq-mvebu-gicp.c
+++ b/drivers/irqchip/irq-mvebu-gicp.c
@@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
return -ENOMEM;
gicp->dev = &pdev->dev;
+ spin_lock_init(&gicp->spi_lock);
gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!gicp->res)
--
2.14.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
2017-10-25 7:23 ` Antoine Tenart
@ 2017-10-25 7:37 ` Gregory CLEMENT
-1 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2017-10-25 7:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Antoine,
On mer., oct. 25 2017, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
You could add the "Cc: stable at vger.kernel.org" flag so the previous
kernels can also benefit of this fix.
Besides this this patch looks obviously correct.
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> drivers/irqchip/irq-mvebu-gicp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> gicp->dev = &pdev->dev;
> + spin_lock_init(&gicp->spi_lock);
>
> gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!gicp->res)
> --
> 2.14.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
@ 2017-10-25 7:37 ` Gregory CLEMENT
0 siblings, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2017-10-25 7:37 UTC (permalink / raw)
To: Antoine Tenart
Cc: tglx, marc.zyngier, jason, andrew, sebastian.hesselbarth,
thomas.petazzoni, miquel.raynal, nadavh, linux-kernel,
linux-arm-kernel
Hi Antoine,
On mer., oct. 25 2017, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
You could add the "Cc: stable@vger.kernel.org" flag so the previous
kernels can also benefit of this fix.
Besides this this patch looks obviously correct.
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> drivers/irqchip/irq-mvebu-gicp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> gicp->dev = &pdev->dev;
> + spin_lock_init(&gicp->spi_lock);
>
> gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!gicp->res)
> --
> 2.14.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
2017-10-25 7:23 ` Antoine Tenart
@ 2017-10-25 7:51 ` Marc Zyngier
-1 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2017-10-25 7:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 25 2017 at 9:23:26 am BST, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/irqchip/irq-mvebu-gicp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> gicp->dev = &pdev->dev;
> + spin_lock_init(&gicp->spi_lock);
>
> gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!gicp->res)
Cc: stable at vger.kernel.org
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thomas, can you please queue this ASAP?
Thanks,
M.
--
Jazz is not dead. It just smells funny.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
@ 2017-10-25 7:51 ` Marc Zyngier
0 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2017-10-25 7:51 UTC (permalink / raw)
To: Antoine Tenart
Cc: tglx, jason, gregory.clement, andrew, sebastian.hesselbarth,
thomas.petazzoni, miquel.raynal, nadavh, linux-kernel,
linux-arm-kernel
On Wed, Oct 25 2017 at 9:23:26 am BST, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/irqchip/irq-mvebu-gicp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> gicp->dev = &pdev->dev;
> + spin_lock_init(&gicp->spi_lock);
>
> gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!gicp->res)
Cc: stable@vger.kernel.org
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thomas, can you please queue this ASAP?
Thanks,
M.
--
Jazz is not dead. It just smells funny.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:irq/urgent] irqchip/irq-mvebu-gicp: Add missing spin_lock init
2017-10-25 7:23 ` Antoine Tenart
` (2 preceding siblings ...)
(?)
@ 2017-10-31 23:39 ` tip-bot for Antoine Tenart
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot for Antoine Tenart @ 2017-10-31 23:39 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, antoine.tenart, tglx, mingo, hpa
Commit-ID: c9bb86338a6bb91e4d32db04feb6b8d423e04d06
Gitweb: https://git.kernel.org/tip/c9bb86338a6bb91e4d32db04feb6b8d423e04d06
Author: Antoine Tenart <antoine.tenart@free-electrons.com>
AuthorDate: Wed, 25 Oct 2017 09:23:26 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 1 Nov 2017 00:35:18 +0100
irqchip/irq-mvebu-gicp: Add missing spin_lock init
A spin lock is used in the irq-mvebu-gicp driver, but it is never
initialized. This patch adds the missing spin_lock_init() call in the
driver's probe function.
Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: gregory.clement@free-electrons.com
Acked-by: marc.zyngier@arm.com
Cc: thomas.petazzoni@free-electrons.com
Cc: andrew@lunn.ch
Cc: jason@lakedaemon.net
Cc: nadavh@marvell.com
Cc: miquel.raynal@free-electrons.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: sebastian.hesselbarth@gmail.com
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20171025072326.21030-1-antoine.tenart@free-electrons.com
---
drivers/irqchip/irq-mvebu-gicp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
index b283fc9..17a4a7b 100644
--- a/drivers/irqchip/irq-mvebu-gicp.c
+++ b/drivers/irqchip/irq-mvebu-gicp.c
@@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
return -ENOMEM;
gicp->dev = &pdev->dev;
+ spin_lock_init(&gicp->spi_lock);
gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!gicp->res)
^ permalink raw reply related [flat|nested] 7+ messages in thread