From: Marc Zyngier <marc.zyngier@arm.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thibaud Cornic <thibaud_cornic@sigmadesigns.com>,
Mason <slash.tmp@free.fr>
Subject: Re: [PATCH v10] PCI: tango: Add MSI controller support
Date: Tue, 22 Aug 2017 21:03:41 +0100 [thread overview]
Message-ID: <86efs3wesi.fsf@arm.com> (raw)
In-Reply-To: <4b93964c-49eb-efbf-f6b2-956c67694182@sigmadesigns.com> (Marc Gonzalez's message of "Tue, 22 Aug 2017 20:02:18 +0200")
On Tue, Aug 22 2017 at 8:02:18 pm BST, Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
> On 22/08/2017 18:29, Marc Zyngier wrote:
>
>> On 22/08/17 15:56, Marc Gonzalez wrote:
>>
>>> #define SMP8759_MUX 0x48
>>> #define SMP8759_TEST_OUT 0x74
>>> +#define SMP8759_STATUS 0x80
>>> +#define SMP8759_ENABLE 0xa0
>>> +#define SMP8759_DOORBELL 0xa002e07c
>>
>> Why is this hardcoded and not coming from the device-tree, just like any
>> other address property?
>
> Since this bus address is software-configurable, I didn't think
> it belonged in the DT. Also, I didn't see anything similar in
> other binding docs, especially
>
> Documentation/devicetree/bindings/interrupt-controller/msi.txt
If that's software configurable, how on Earth did you pick the address?
How do you ensure that it doesn't conflict with DMA? How is it
configured into the RC?
M.
--
Jazz is not dead. It just smells funny.
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10] PCI: tango: Add MSI controller support
Date: Tue, 22 Aug 2017 21:03:41 +0100 [thread overview]
Message-ID: <86efs3wesi.fsf@arm.com> (raw)
In-Reply-To: <4b93964c-49eb-efbf-f6b2-956c67694182@sigmadesigns.com> (Marc Gonzalez's message of "Tue, 22 Aug 2017 20:02:18 +0200")
On Tue, Aug 22 2017 at 8:02:18 pm BST, Marc Gonzalez <marc_gonzalez@sigmadesigns.com> wrote:
> On 22/08/2017 18:29, Marc Zyngier wrote:
>
>> On 22/08/17 15:56, Marc Gonzalez wrote:
>>
>>> #define SMP8759_MUX 0x48
>>> #define SMP8759_TEST_OUT 0x74
>>> +#define SMP8759_STATUS 0x80
>>> +#define SMP8759_ENABLE 0xa0
>>> +#define SMP8759_DOORBELL 0xa002e07c
>>
>> Why is this hardcoded and not coming from the device-tree, just like any
>> other address property?
>
> Since this bus address is software-configurable, I didn't think
> it belonged in the DT. Also, I didn't see anything similar in
> other binding docs, especially
>
> Documentation/devicetree/bindings/interrupt-controller/msi.txt
If that's software configurable, how on Earth did you pick the address?
How do you ensure that it doesn't conflict with DMA? How is it
configured into the RC?
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2017-08-22 20:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:56 [PATCH v10] PCI: tango: Add MSI controller support Marc Gonzalez
2017-08-22 14:56 ` Marc Gonzalez
2017-08-22 16:29 ` Marc Zyngier
2017-08-22 16:29 ` Marc Zyngier
2017-08-22 18:02 ` Marc Gonzalez
2017-08-22 18:02 ` Marc Gonzalez
2017-08-22 20:03 ` Marc Zyngier [this message]
2017-08-22 20:03 ` Marc Zyngier
2017-08-24 17:04 ` Bjorn Helgaas
2017-08-24 17:04 ` Bjorn Helgaas
2017-08-24 17:51 ` Marc Gonzalez
2017-08-24 17:51 ` Marc Gonzalez
2017-08-24 18:35 ` Ard Biesheuvel
2017-08-24 18:35 ` Ard Biesheuvel
2017-08-24 20:53 ` Mason
2017-08-24 20:53 ` Mason
2017-08-25 7:54 ` Marc Zyngier
2017-08-25 7:54 ` Marc Zyngier
2017-08-25 8:56 ` Mason
2017-08-25 8:56 ` Mason
2017-08-25 15:01 ` Mason
2017-08-25 15:01 ` Mason
2017-08-25 15:25 ` Robin Murphy
2017-08-25 15:25 ` Robin Murphy
2017-08-25 15:35 ` Mason
2017-08-25 15:35 ` Mason
2017-08-25 15:45 ` Robin Murphy
2017-08-25 15:45 ` Robin Murphy
2017-08-25 16:44 ` Mason
2017-08-25 16:44 ` Mason
2017-08-26 13:08 ` Marc Zyngier
2017-08-26 13:08 ` Marc Zyngier
2017-08-26 18:12 ` Mason
2017-08-26 18:12 ` Mason
2017-08-28 16:13 ` Mason
2017-08-28 16:13 ` Mason
2017-09-18 21:30 ` Rob Herring
2017-09-18 21:30 ` Rob Herring
2017-09-19 10:41 ` Mason
2017-09-19 10:41 ` Mason
2017-08-23 12:59 ` Marc Gonzalez
2017-08-23 12:59 ` Marc Gonzalez
2017-08-24 17:01 ` Bjorn Helgaas
2017-08-24 17:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86efs3wesi.fsf@arm.com \
--to=marc.zyngier@arm.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=slash.tmp@free.fr \
--cc=thibaud_cornic@sigmadesigns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.