All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arm64: cpucaps: Remove stale comment about keeping capabilities sorted
@ 2026-07-30 13:27 Will Deacon
  2026-07-30 13:41 ` Marc Zyngier
  0 siblings, 1 reply; 2+ messages in thread
From: Will Deacon @ 2026-07-30 13:27 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Will Deacon, Catalin Marinas, Mark Rutland, Fuad Tabba,
	Marc Zyngier

There is no functional requirement to keep the entries in arm64's
tools/cpucaps file sorted alphabetically and, in fact, they have fallen
out of order over time. Given that only the arm64 tree touches this file
and the perceived benefit of sorting was to help with conflicts, just
remove the stale comment and accept that we're collectively not very
good at the alphabet.

In the limited cases where a specific ordering is important, we enforce
it through build-time assertions (e.g. in can_use_gic_priorities()).

Cc: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Fuad Tabba <fuad.tabba@linux.dev>
Reported-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>
---

v1: https://lore.kernel.org/r/20260723130233.3123-1-will@kernel.org

 arch/arm64/tools/cpucaps | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/tools/cpucaps b/arch/arm64/tools/cpucaps
index 9b85a84f6fd4..3fcac789b0a4 100644
--- a/arch/arm64/tools/cpucaps
+++ b/arch/arm64/tools/cpucaps
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# Internal CPU capabilities constants, keep this list sorted
+# Internal CPU capabilities constants
 
 ALWAYS_BOOT
 ALWAYS_SYSTEM
-- 
2.55.0.508.g3f0d502094-goog



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: cpucaps: Remove stale comment about keeping capabilities sorted
  2026-07-30 13:27 [PATCH v2] arm64: cpucaps: Remove stale comment about keeping capabilities sorted Will Deacon
@ 2026-07-30 13:41 ` Marc Zyngier
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2026-07-30 13:41 UTC (permalink / raw)
  To: Will Deacon; +Cc: linux-arm-kernel, Catalin Marinas, Mark Rutland, Fuad Tabba

On Thu, 30 Jul 2026 14:27:57 +0100,
Will Deacon <will@kernel.org> wrote:
> 
> There is no functional requirement to keep the entries in arm64's
> tools/cpucaps file sorted alphabetically and, in fact, they have fallen
> out of order over time. Given that only the arm64 tree touches this file
> and the perceived benefit of sorting was to help with conflicts, just
> remove the stale comment and accept that we're collectively not very
> good at the alphabet.
> 
> In the limited cases where a specific ordering is important, we enforce
> it through build-time assertions (e.g. in can_use_gic_priorities()).
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Fuad Tabba <fuad.tabba@linux.dev>
> Reported-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Will Deacon <will@kernel.org>

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-30 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 13:27 [PATCH v2] arm64: cpucaps: Remove stale comment about keeping capabilities sorted Will Deacon
2026-07-30 13:41 ` Marc Zyngier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.