[cocci] GNU-style function calls

[cocci] GNU-style function calls

[Arsen Arsenović]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

Hi!

I work on GCC, meaning we use GNU-style function calls, where the
call operator is preceded by a whitespace, like so:

  foo (a, b);

I've had decent luck with applying Cocci to the codebase, but if Cocci
rewrites a call, it removes the whitespace preceding the call operator:

  /tmp$ cat test.cc
  void
  thing ()
  {
    foo (a, b);
  }
  /tmp$ cat test.cocci
  @@
  expression x, y;
  @@

  - foo (x, y);
  + foo (y, x);
  /tmp$ spatch --sp-file test.cocci --c++=14 test.cc
  init_defs_builtins: /usr/lib64/coccinelle/standard.h
  HANDLING: test.cc
  diff = 
  --- test.cc
  +++ /tmp/cocci-output-157607-636042-test.cc
  @@ -1,5 +1,5 @@
   void
   thing ()
   {
  -  foo (a, b);
  +  foo(b, a);
   }
  /tmp$ 

This isn't too much of a problem; I go back and modify the function
calls manually, but it would be nice if Cocci handled it.

Is it possible to keep the spaces in line with the code style w/ Cocci?

Thanks in advance!  Have a lovely day.
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 430 bytes --]

Re: [cocci] GNU-style function calls

[Julia Lawall]

There is a —simple-spacing argument where it should preserve the spacing you put in the semantic patch.
Sent from my iPhone

> On 6 Jul 2026, at 13:50, Arsen Arsenović <aarsenovic@baylibre.com> wrote:
> 
> Hi!
> 
> I work on GCC, meaning we use GNU-style function calls, where the
> call operator is preceded by a whitespace, like so:
> 
>  foo (a, b);
> 
> I've had decent luck with applying Cocci to the codebase, but if Cocci
> rewrites a call, it removes the whitespace preceding the call operator:
> 
>  /tmp$ cat test.cc
>  void
>  thing ()
>  {
>    foo (a, b);
>  }
>  /tmp$ cat test.cocci
>  @@
>  expression x, y;
>  @@
> 
>  - foo (x, y);
>  + foo (y, x);
>  /tmp$ spatch --sp-file test.cocci --c++=14 test.cc
>  init_defs_builtins: /usr/lib64/coccinelle/standard.h
>  HANDLING: test.cc
>  diff =
>  --- test.cc
>  +++ /tmp/cocci-output-157607-636042-test.cc
>  @@ -1,5 +1,5 @@
>   void
>   thing ()
>   {
>  -  foo (a, b);
>  +  foo(b, a);
>   }
>  /tmp$
> 
> This isn't too much of a problem; I go back and modify the function
> calls manually, but it would be nice if Cocci handled it.
> 
> Is it possible to keep the spaces in line with the code style w/ Cocci?
> 
> Thanks in advance!  Have a lovely day.
> --
> Arsen Arsenović
> <signature.asc>

Re: [cocci] GNU-style function calls

[Arsen Arsenović]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi Julia!

Julia Lawall <Julia.Lawall@inria.fr> writes:

> There is a —simple-spacing argument where it should preserve the spacing you put in the semantic patch.

Ah, yes, indeed, that works perfectly!

Thank you!  Cocci is awesome :-)

Have a lovely evening.
-- 
Arsen Arsenović

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 430 bytes --]