* Patch to add hp t5745 thin client to no-lvds list
@ 2012-01-04 19:08 Marc Gariépy
2012-01-04 19:58 ` Adam Jackson
0 siblings, 1 reply; 11+ messages in thread
From: Marc Gariépy @ 2012-01-04 19:08 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 771 bytes --]
Hello,
I've been directed here by Stephane Graber. I need to blacklist the LVDS
port on some hp t5745 thin client.
Here is the bug link:
https://bugs.launchpad.net/bugs/911916
And i attached the following patch to this bug:
--- linux-3.2.0/drivers/gpu/drm/i915/intel_lvds.c 2011-12-24
10:23:08.000000000 -0500
+++ intel_lvds.c 2012-01-04 14:03:49.134573275 -0500
@@ -723,6 +723,14 @@
DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
},
},
+ {
+ .callback = intel_no_lvds_dmi_callback,
+ .ident = "Hewlett-Packard t5745",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
+ DMI_MATCH(DMI_BOARD_NAME, "hp st5745"),
+ },
+ },
{ } /* terminating entry */
};
Thanks
Marc Gariepy
[-- Attachment #1.2: Type: text/html, Size: 949 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-04 19:08 Patch to add hp t5745 thin client to no-lvds list Marc Gariépy @ 2012-01-04 19:58 ` Adam Jackson 2012-01-04 22:50 ` Marc Gariépy 0 siblings, 1 reply; 11+ messages in thread From: Adam Jackson @ 2012-01-04 19:58 UTC (permalink / raw) To: Marc Gariépy; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 545 bytes --] On Wed, 2012-01-04 at 14:08 -0500, Marc Gariépy wrote: > Hello, > > I've been directed here by Stephane Graber. I need to blacklist the > LVDS port on some hp t5745 thin client. > > Here is the bug link: > https://bugs.launchpad.net/bugs/911916 Does this actually work? The bug above doesn't include the dmidecode output, and... > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_BOARD_NAME, "hp st5745"), I would normally expect HP to capitalize their own name correctly. - ajax [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 198 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-04 19:58 ` Adam Jackson @ 2012-01-04 22:50 ` Marc Gariépy 2012-01-17 16:31 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Marc Gariépy @ 2012-01-04 22:50 UTC (permalink / raw) To: Adam Jackson; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 1349 bytes --] Sorry for the mistake, i made a typo when correcting the indentation issue i had. here is the correct patch and also the dmidecode from the thin client. --- linux-3.2.0/drivers/gpu/drm/i915/intel_lvds.c 2011-12-24 10:23:08.000000000 -0500 +++ intel_lvds.c 2012-01-04 14:03:49.134573275 -0500 @@ -723,6 +723,14 @@ DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard t5745", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), + }, + }, { } /* terminating entry */ }; On Wed, Jan 4, 2012 at 2:58 PM, Adam Jackson <ajax@redhat.com> wrote: > On Wed, 2012-01-04 at 14:08 -0500, Marc Gariépy wrote: > > Hello, > > > > I've been directed here by Stephane Graber. I need to blacklist the > > LVDS port on some hp t5745 thin client. > > > > Here is the bug link: > > https://bugs.launchpad.net/bugs/911916 > > Does this actually work? The bug above doesn't include the dmidecode > output, and... > > > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), > > + DMI_MATCH(DMI_BOARD_NAME, "hp st5745"), > > I would normally expect HP to capitalize their own name correctly. > > - ajax > [-- Attachment #1.2: Type: text/html, Size: 1863 bytes --] [-- Attachment #2: dmidecode-hp-t5745 --] [-- Type: application/octet-stream, Size: 12515 bytes --] # dmidecode 2.9 SMBIOS 2.6 present. 43 structures occupying 1570 bytes. Table at 0x000FC540. Handle 0x0000, DMI type 0, 24 bytes BIOS Information Vendor: American Megatrends Inc. Version: 786R8 v0.16s3 Release Date: 08/19/2009 Address: 0xE0000 Runtime Size: 128 kB ROM Size: 1024 kB Characteristics: PCI is supported PNP is supported BIOS is upgradeable BIOS shadowing is allowed ESCD support is available Boot from CD is supported Selectable boot is supported EDD is supported 5.25"/360 KB floppy services are supported (int 13h) 5.25"/1.2 MB floppy services are supported (int 13h) 3.5"/720 KB floppy services are supported (int 13h) 3.5"/2.88 MB floppy services are supported (int 13h) Print screen service is supported (int 5h) 8042 keyboard services are supported (int 9h) Serial services are supported (int 14h) Printer services are supported (int 17h) CGA/mono video services are supported (int 10h) ACPI is supported USB legacy is supported LS-120 boot is supported ATAPI Zip drive boot is supported BIOS boot specification is supported Function key-initiated network boot is supported Targeted content distribution is supported BIOS Revision: 8.15 Handle 0x0001, DMI type 1, 27 bytes System Information Manufacturer: Hewlett-Packard Product Name: hp t5745 Version: Serial Number: CNV9330BSX UUID: D12A37A0-FE8D-11D5-8CD7-E2DCC4DD8D9A Wake-up Type: Power Switch SKU Number: Climbers Family: 103C_53302C Handle 0x0002, DMI type 2, 15 bytes Base Board Information Manufacturer: Hewlett-Packard Product Name: 3641h Version: Serial Number: CNV9330BSX Asset Tag: Climbers Features: Board is a hosting board Board is replaceable Location In Chassis: Climbers Chassis Handle: 0x0003 Type: Motherboard Contained Object Handles: 0 Handle 0x0003, DMI type 3, 21 bytes Chassis Information Manufacturer: Hewlett-Packard Type: Desktop Lock: Not Present Version: Serial Number: CNV9330BSX Asset Tag: Asset tracking Boot-up State: Safe Power Supply State: Safe Thermal State: Safe Security Status: None OEM Information: 0x00000000 Height: Unspecified Number Of Power Cords: 1 Contained Elements: 0 Handle 0x0004, DMI type 4, 42 bytes Processor Information Socket Designation: CPU 1 Type: Central Processor Family: Unknown Manufacturer: Intel ID: C2 06 01 00 FF FB E9 BF Version: Intel(R) Atom(TM) CPU N280 @ 1.66GHz Voltage: 1.0 V External Clock: 167 MHz Max Speed: 1666 MHz Current Speed: 1666 MHz Status: Populated, Enabled Upgrade: None L1 Cache Handle: 0x0005 L2 Cache Handle: 0x0006 L3 Cache Handle: Not Provided Serial Number: To Be Filled By O.E.M. Asset Tag: To Be Filled By O.E.M. Part Number: To Be Filled By O.E.M. Core Count: 1 Core Enabled: 1 Thread Count: 2 Characteristics: None Handle 0x0005, DMI type 7, 19 bytes Cache Information Socket Designation: L1-Cache Configuration: Enabled, Not Socketed, Level 1 Operational Mode: Write Back Location: Internal Installed Size: 24 KB Maximum Size: 24 KB Supported SRAM Types: Burst Installed SRAM Type: Burst Speed: Unknown Error Correction Type: Unknown System Type: Data Associativity: Other Handle 0x0006, DMI type 7, 19 bytes Cache Information Socket Designation: L2-Cache Configuration: Enabled, Not Socketed, Level 2 Operational Mode: Write Back Location: Internal Installed Size: 512 KB Maximum Size: 512 KB Supported SRAM Types: Burst Installed SRAM Type: Burst Speed: Unknown Error Correction Type: Unknown System Type: Unified Associativity: 8-way Set-associative Handle 0x0007, DMI type 5, 20 bytes Memory Controller Information Error Detecting Method: None Error Correcting Capabilities: None Supported Interleave: One-way Interleave Current Interleave: One-way Interleave Maximum Memory Module Size: 4096 MB Maximum Total Memory Size: 8192 MB Supported Speeds: Other Supported Memory Types: SIMM SDRAM Memory Module Voltage: 3.3 V Associated Memory Slots: 2 0x0008 0x0009 Enabled Error Correcting Capabilities: None Handle 0x0008, DMI type 6, 12 bytes Memory Module Information Socket Designation: DIMM0 Bank Connections: 0 1 Current Speed: Unknown Type: DIMM SDRAM Installed Size: 1024 MB (Single-bank Connection) Enabled Size: 1024 MB (Single-bank Connection) Error Status: OK Handle 0x0009, DMI type 6, 12 bytes Memory Module Information Socket Designation: DIMM1 Bank Connections: 4 5 Current Speed: Unknown Type: DIMM SDRAM Installed Size: 2048 MB (Double-bank Connection) Enabled Size: 2048 MB (Double-bank Connection) Error Status: OK Handle 0x000A, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: COM1 Internal Connector Type: 9 Pin Dual Inline (pin 10 cut) External Reference Designator: COM A External Connector Type: DB-9 male Port Type: Serial Port 16450 Compatible Handle 0x000B, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: COM2 Internal Connector Type: 9 Pin Dual Inline (pin 10 cut) External Reference Designator: COM B External Connector Type: DB-9 male Port Type: Serial Port 16450 Compatible Handle 0x000C, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: LPT1 Internal Connector Type: DB-25 female External Reference Designator: PARALLEL External Connector Type: DB-25 female Port Type: Parallel Port ECP/EPP Handle 0x000D, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB0 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x000E, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB1 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x000F, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB2 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0010, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB3 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0011, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB4 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0012, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB5 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0013, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB6 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0014, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: USB7 External Connector Type: Access Bus (USB) Port Type: USB Handle 0x0015, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: LAN External Connector Type: RJ-45 Port Type: Network Port Handle 0x0016, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: VGA External Connector Type: DB-15 female Port Type: Video Port Handle 0x0017, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: Line out External Connector Type: Mini Jack (headphones) Port Type: Audio Port Handle 0x0018, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: Microphone External Connector Type: Mini Jack (headphones) Port Type: Audio Port Handle 0x0019, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: Keyboard External Connector Type: PS/2 Port Type: Keyboard Port Handle 0x001A, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: Null Internal Connector Type: None External Reference Designator: Mouse External Connector Type: PS/2 Port Type: Mouse Port Handle 0x001B, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: PRIMARY IDE Internal Connector Type: On Board IDE External Reference Designator: Not Specified External Connector Type: None Port Type: Other Handle 0x001C, DMI type 8, 9 bytes Port Connector Information Internal Reference Designator: SECONDARY IDE Internal Connector Type: On Board IDE External Reference Designator: Not Specified External Connector Type: None Port Type: Other Handle 0x001D, DMI type 9, 17 bytes System Slot Information Designation: PCI-X Type: 32-bit PCI-X Current Usage: Available Length: Long ID: 0 Characteristics: 5.0 V is provided PME signal is supported Handle 0x001E, DMI type 11, 5 bytes OEM Strings String 1: $OSTYPE30008 String 2: $813AP01020G0LNUX Handle 0x001F, DMI type 13, 22 bytes BIOS Language Information Installable Languages: 3 en|US|iso8859-1 es|ES|iso8859-1 de|DE|iso8859-1 Currently Installed Language: en|US|iso8859-1 Handle 0x0020, DMI type 16, 15 bytes Physical Memory Array Location: System Board Or Motherboard Use: System Memory Error Correction Type: None Maximum Capacity: 8 GB Error Information Handle: Not Provided Number Of Devices: 2 Handle 0x0021, DMI type 19, 15 bytes Memory Array Mapped Address Starting Address: 0x00000000000 Ending Address: 0x000BFFFFFFF Range Size: 3 GB Physical Array Handle: 0x0020 Partition Width: 0 Handle 0x0022, DMI type 17, 28 bytes Memory Device Array Handle: 0x0020 Error Information Handle: Not Provided Total Width: 64 bits Data Width: 64 bits Size: 1024 MB Form Factor: SODIMM Set: None Locator: DIMM0 Bank Locator: BANK0 Type: DDR2 Type Detail: Synchronous Speed: Unknown Manufacturer: Micron Serial Number: 0F4140DB Asset Tag: AssetTagNum0 Part Number: 8JSF12864HZ-1G4F1 Handle 0x0023, DMI type 20, 19 bytes Memory Device Mapped Address Starting Address: 0x00000000000 Ending Address: 0x0003FFFFFFF Range Size: 1 GB Physical Device Handle: 0x0022 Memory Array Mapped Address Handle: 0x0021 Partition Row Position: 1 Handle 0x0024, DMI type 17, 28 bytes Memory Device Array Handle: 0x0020 Error Information Handle: Not Provided Total Width: 64 bits Data Width: 64 bits Size: 2048 MB Form Factor: SODIMM Set: None Locator: DIMM1 Bank Locator: BANK1 Type: DDR2 Type Detail: Synchronous Speed: Unknown Manufacturer: Manufacturer01 Serial Number: 4C1D1D12 Asset Tag: AssetTagNum1 Part Number: 9905428-026.A01LF Handle 0x0025, DMI type 20, 19 bytes Memory Device Mapped Address Starting Address: 0x00040000000 Ending Address: 0x000BFFFFFFF Range Size: 2 GB Physical Device Handle: 0x0024 Memory Array Mapped Address Handle: 0x0021 Partition Row Position: 1 Handle 0x0026, DMI type 16, 15 bytes Physical Memory Array Location: System Board Or Motherboard Use: Flash Memory Error Correction Type: None Maximum Capacity: 1 MB Error Information Handle: Not Provided Number Of Devices: 1 Handle 0x0027, DMI type 19, 15 bytes Memory Array Mapped Address Starting Address: 0x000FFF00000 Ending Address: 0x000FFFFFFFF Range Size: 1 MB Physical Array Handle: 0x0026 Partition Width: 0 Handle 0x0028, DMI type 17, 28 bytes Memory Device Array Handle: 0x0026 Error Information Handle: Not Provided Total Width: 8 bits Data Width: 8 bits Size: 1024 kB Form Factor: Chip Set: None Locator: U24 Bank Locator: Type: Flash Type Detail: Non-Volatile Speed: 33 MHz (30.3 ns) Manufacturer: ATMEL Serial Number: Asset Tag: Part Number: 26DF081/161/321 Handle 0x0029, DMI type 20, 19 bytes Memory Device Mapped Address Starting Address: 0x000FFF00000 Ending Address: 0x000FFFFFFFF Range Size: 1 MB Physical Device Handle: 0x0028 Memory Array Mapped Address Handle: 0x0027 Partition Row Position: 1 Handle 0x002A, DMI type 127, 4 bytes End Of Table [-- Attachment #3: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-04 22:50 ` Marc Gariépy @ 2012-01-17 16:31 ` Daniel Vetter 2012-01-23 16:32 ` Adam Jackson 0 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2012-01-17 16:31 UTC (permalink / raw) To: Marc Gariépy; +Cc: dri-devel On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote: > Sorry for the mistake, i made a typo when correcting the indentation issue > i had. > here is the correct patch and also the dmidecode from the thin client. Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also please combine this with the other no-lvds patch. I'd also like Adam to ack it, so put him on cc when resubmitting. -Daniel > > --- linux-3.2.0/drivers/gpu/drm/i915/intel_lvds.c 2011-12-24 > 10:23:08.000000000 -0500 > +++ intel_lvds.c 2012-01-04 14:03:49.134573275 -0500 > @@ -723,6 +723,14 @@ > DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), > }, > }, > + { > + .callback = intel_no_lvds_dmi_callback, > + .ident = "Hewlett-Packard t5745", > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), > + }, > + }, > > { } /* terminating entry */ > }; > > > On Wed, Jan 4, 2012 at 2:58 PM, Adam Jackson <ajax@redhat.com> wrote: > > > On Wed, 2012-01-04 at 14:08 -0500, Marc Gariépy wrote: > > > Hello, > > > > > > I've been directed here by Stephane Graber. I need to blacklist the > > > LVDS port on some hp t5745 thin client. > > > > > > Here is the bug link: > > > https://bugs.launchpad.net/bugs/911916 > > > > Does this actually work? The bug above doesn't include the dmidecode > > output, and... > > > > > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), > > > + DMI_MATCH(DMI_BOARD_NAME, "hp st5745"), > > > > I would normally expect HP to capitalize their own name correctly. > > > > - ajax > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-17 16:31 ` Daniel Vetter @ 2012-01-23 16:32 ` Adam Jackson 2012-01-26 13:38 ` Marc Gariépy 0 siblings, 1 reply; 11+ messages in thread From: Adam Jackson @ 2012-01-23 16:32 UTC (permalink / raw) To: Daniel Vetter; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 605 bytes --] On Tue, 2012-01-17 at 17:31 +0100, Daniel Vetter wrote: > On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote: > > Sorry for the mistake, i made a typo when correcting the indentation issue > > i had. > > here is the correct patch and also the dmidecode from the thin client. > > Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also > please combine this with the other no-lvds patch. I'd also like Adam to > ack it, so put him on cc when resubmitting. I would like to see my question addressed before acking. Pretty sure dmi matching is case sensitive. - ajax [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 198 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-23 16:32 ` Adam Jackson @ 2012-01-26 13:38 ` Marc Gariépy 2012-02-03 21:48 ` Marc Gariépy 2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy 0 siblings, 2 replies; 11+ messages in thread From: Marc Gariépy @ 2012-01-26 13:38 UTC (permalink / raw) To: Adam Jackson; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 915 bytes --] Hello, I attached the dmidecode on launchpad bug. Here is what i have in dmidecode for the hp t5745. System Information Manufacturer: Hewlett-Packard Product Name: hp t5745 Marc On Mon, Jan 23, 2012 at 11:32 AM, Adam Jackson <ajax@redhat.com> wrote: > On Tue, 2012-01-17 at 17:31 +0100, Daniel Vetter wrote: > > On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote: > > > Sorry for the mistake, i made a typo when correcting the indentation > issue > > > i had. > > > here is the correct patch and also the dmidecode from the thin client. > > > > Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also > > please combine this with the other no-lvds patch. I'd also like Adam to > > ack it, so put him on cc when resubmitting. > > I would like to see my question addressed before acking. Pretty sure > dmi matching is case sensitive. > > - ajax > [-- Attachment #1.2: Type: text/html, Size: 1246 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Patch to add hp t5745 thin client to no-lvds list 2012-01-26 13:38 ` Marc Gariépy @ 2012-02-03 21:48 ` Marc Gariépy 2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy 1 sibling, 0 replies; 11+ messages in thread From: Marc Gariépy @ 2012-02-03 21:48 UTC (permalink / raw) To: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 2548 bytes --] Hello, Here is the patch made from the git git:// git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git The dmidecode for hp t5745 and hp st5747 are attached to their respective bugs: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911916 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911920 This patch disable the LVDS on hp t5745 and hp st5747 thin client. diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 798f6e1..069f9ba 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -731,6 +731,22 @@ static const struct dmi_system_id intel_no_lvds[] = { DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard t5745", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), + }, + }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard st5747", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp st5747"), + }, + }, { } /* terminating entry */ }; Signed-off-by: Marc Gariépy <mgariepy@ubuntu.com> On Thu, Jan 26, 2012 at 8:38 AM, Marc Gariépy <mgariepy@ubuntu.com> wrote: > Hello, > > I attached the dmidecode on launchpad bug. > > Here is what i have in dmidecode for the hp t5745. > > System Information > Manufacturer: Hewlett-Packard > Product Name: hp t5745 > > Marc > > > > On Mon, Jan 23, 2012 at 11:32 AM, Adam Jackson <ajax@redhat.com> wrote: > >> On Tue, 2012-01-17 at 17:31 +0100, Daniel Vetter wrote: >> > On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote: >> > > Sorry for the mistake, i made a typo when correcting the indentation >> issue >> > > i had. >> > > here is the correct patch and also the dmidecode from the thin client. >> > >> > Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also >> > please combine this with the other no-lvds patch. I'd also like Adam to >> > ack it, so put him on cc when resubmitting. >> >> I would like to see my question addressed before acking. Pretty sure >> dmi matching is case sensitive. >> >> - ajax >> > > [-- Attachment #1.2: Type: text/html, Size: 3608 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client 2012-01-26 13:38 ` Marc Gariépy 2012-02-03 21:48 ` Marc Gariépy @ 2012-02-09 14:35 ` Marc Gariepy 2012-02-13 8:42 ` Daniel Vetter 2012-02-22 16:29 ` Daniel Vetter 1 sibling, 2 replies; 11+ messages in thread From: Marc Gariepy @ 2012-02-09 14:35 UTC (permalink / raw) To: ajax; +Cc: dri-devel Add a no_lvds quirk for the HP t5745 and HP st5747 thin clients dmidecode for those thin clients are attached in thoses bugs: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911916 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911920 Signed-off-by: Marc Gariepy <mgariepy@ubuntu.com> --- Hello, this patch was previously posted on dri-devel and this is now reformated. drivers/gpu/drm/i915/intel_lvds.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 798f6e1..069f9ba 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c @@ -731,6 +731,22 @@ static const struct dmi_system_id intel_no_lvds[] = { DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard t5745", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"), + }, + }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Hewlett-Packard st5747", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_BOARD_NAME, "hp st5747"), + }, + }, { } /* terminating entry */ }; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client 2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy @ 2012-02-13 8:42 ` Daniel Vetter 2012-02-22 16:29 ` Daniel Vetter 1 sibling, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2012-02-13 8:42 UTC (permalink / raw) To: Marc Gariepy, Adam Jackson; +Cc: dri-devel On Thu, Feb 09, 2012 at 09:35:21AM -0500, Marc Gariepy wrote: > Add a no_lvds quirk for the HP t5745 and HP st5747 thin clients > > dmidecode for those thin clients are attached in thoses bugs: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911916 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911920 > > > Signed-off-by: Marc Gariepy <mgariepy@ubuntu.com> Adam, can I have your ack on this? Thanks, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client 2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy 2012-02-13 8:42 ` Daniel Vetter @ 2012-02-22 16:29 ` Daniel Vetter 2012-02-22 21:00 ` Keith Packard 1 sibling, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2012-02-22 16:29 UTC (permalink / raw) To: Marc Gariepy; +Cc: dri-devel On Thu, Feb 09, 2012 at 09:35:21AM -0500, Marc Gariepy wrote: > Add a no_lvds quirk for the HP t5745 and HP st5747 thin clients > > dmidecode for those thin clients are attached in thoses bugs: > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911916 > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/911920 > > > Signed-off-by: Marc Gariepy <mgariepy@ubuntu.com> Queued for -next (with Adam's Acked-by from irc added), thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client 2012-02-22 16:29 ` Daniel Vetter @ 2012-02-22 21:00 ` Keith Packard 0 siblings, 0 replies; 11+ messages in thread From: Keith Packard @ 2012-02-22 21:00 UTC (permalink / raw) To: Daniel Vetter, Marc Gariepy; +Cc: dri-devel <#part sign=pgpmime> On Wed, 22 Feb 2012 17:29:59 +0100, Daniel Vetter <daniel@ffwll.ch> wrote: > Queued for -next (with Adam's Acked-by from irc added), thanks for the > patch. Should these be pulled into -fixes? -- keith.packard@intel.com ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-02-22 21:00 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-04 19:08 Patch to add hp t5745 thin client to no-lvds list Marc Gariépy 2012-01-04 19:58 ` Adam Jackson 2012-01-04 22:50 ` Marc Gariépy 2012-01-17 16:31 ` Daniel Vetter 2012-01-23 16:32 ` Adam Jackson 2012-01-26 13:38 ` Marc Gariépy 2012-02-03 21:48 ` Marc Gariépy 2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy 2012-02-13 8:42 ` Daniel Vetter 2012-02-22 16:29 ` Daniel Vetter 2012-02-22 21:00 ` Keith Packard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.