Re: [PATCH v2 0/4] KVM: arm64: Use 'generic' vCPU target across all uarches

[Marc Zyngier <maz@kernel.org>]

On Mon, 10 Jul 2023 20:31:36 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> kvm_vcpu_init::target is quite useless at this point. We don't do any
> uarch-specific emulation in the first place, and require userspace
> select the 'generic' vCPU target on all but a few implementations.
> 
> Small series to (1) clean up usage of the target value in the kernel and
> (2) switch to the 'generic' target on implementations that previously
> had their own target values. The implementation-specific values are
> still tolerated, though, to avoid UAPI breakage.
> 
> v1: https://lore.kernel.org/kvmarm/20230623194258.2648987-1-oliver.upton@linux.dev/
> 
> v1 -> v2:
>  - Set the generic v8 target in the kvm_vcpu_init struct initializer
>    (Marc)
>  - Use the kvm_vcpu_initialized() helper (Zenghui)
>  - Collect Zenghui's ack/reviews (Thanks!)
> 
> Oliver Upton (4):
>   KVM: arm64: Delete pointless switch statement in kvm_reset_vcpu()
>   KVM: arm64: Remove pointless check for changed init target
>   KVM: arm64: Replace vCPU target with a configuration flag
>   KVM: arm64: Always return generic v8 as the preferred target
> 
>  arch/arm64/include/asm/kvm_host.h |  6 +++---
>  arch/arm64/kvm/arm.c              | 24 +++++++++++-------------
>  arch/arm64/kvm/guest.c            | 15 ---------------
>  arch/arm64/kvm/hyp/nvhe/switch.c  |  2 +-
>  arch/arm64/kvm/reset.c            | 25 ++++++++++---------------
>  5 files changed, 25 insertions(+), 47 deletions(-)
> 
> 
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5

Looks great to me. This is 6.6 material, right? If so, I'll earmark it
as such.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.