All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Tim Harvey <tharvey@gateworks.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Al Cooper <alcooperx@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] irqchip/gic-v3: Claim iomem resources
Date: Wed, 01 Mar 2023 16:24:07 +0000	[thread overview]
Message-ID: <86k000l9so.wl-maz@kernel.org> (raw)
In-Reply-To: <410c8561-a7e3-6a3f-b634-08adaa806111@arm.com>

On Wed, 01 Mar 2023 16:12:58 +0000,
Robin Murphy <robin.murphy@arm.com> wrote:
> 
> On 2023-02-28 23:22, Marc Zyngier wrote:
> > On Tue, 28 Feb 2023 23:11:15 +0000,
> > Tim Harvey <tharvey@gateworks.com> wrote:
> >> 
> >> I have bisected a kernel issue where octeontx (CN803x) will hang on
> >> reboot caused by commit c0db06fd0993 ("mmc: core: Disable card detect
> >> during shutdown"). This commit made it into 5.16 and stable kernels.
> >> I've found that the patch here which is commit 2b2cd74a06c3 resolves
> >> this hang but I'm not entirely clear why.
> >> 
> >> Does anyone have a good explanation of why the hang occurs in the
> >> first place and why this resolves it? I would like to get the proper
> >> fix into the affected stable branches.
> > 
> > Wild guess: the reservation prevents some other driver from probing
> > because the firmware describes overlapping ranges, and that driver is
> > what is causing your above hang.
> 
> Indeed, according to [1], the GIC appears to overlap one of the "PCIe"
> windows of &ecam0, which conveniently appears to be the parent of the
> MMC controller as well.

Huh, quality firmware. So clearly nothing to backport. Just a DT
update to distribute... :-/

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Tim Harvey <tharvey@gateworks.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Al Cooper <alcooperx@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] irqchip/gic-v3: Claim iomem resources
Date: Wed, 01 Mar 2023 16:24:07 +0000	[thread overview]
Message-ID: <86k000l9so.wl-maz@kernel.org> (raw)
In-Reply-To: <410c8561-a7e3-6a3f-b634-08adaa806111@arm.com>

On Wed, 01 Mar 2023 16:12:58 +0000,
Robin Murphy <robin.murphy@arm.com> wrote:
> 
> On 2023-02-28 23:22, Marc Zyngier wrote:
> > On Tue, 28 Feb 2023 23:11:15 +0000,
> > Tim Harvey <tharvey@gateworks.com> wrote:
> >> 
> >> I have bisected a kernel issue where octeontx (CN803x) will hang on
> >> reboot caused by commit c0db06fd0993 ("mmc: core: Disable card detect
> >> during shutdown"). This commit made it into 5.16 and stable kernels.
> >> I've found that the patch here which is commit 2b2cd74a06c3 resolves
> >> this hang but I'm not entirely clear why.
> >> 
> >> Does anyone have a good explanation of why the hang occurs in the
> >> first place and why this resolves it? I would like to get the proper
> >> fix into the affected stable branches.
> > 
> > Wild guess: the reservation prevents some other driver from probing
> > because the firmware describes overlapping ranges, and that driver is
> > what is causing your above hang.
> 
> Indeed, according to [1], the GIC appears to overlap one of the "PCIe"
> windows of &ecam0, which conveniently appears to be the parent of the
> MMC controller as well.

Huh, quality firmware. So clearly nothing to backport. Just a DT
update to distribute... :-/

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2023-03-01 16:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 15:28 [RFC PATCH] irqchip/gic-v3: Claim iomem resources Robin Murphy
2022-04-12 15:28 ` Robin Murphy
2023-02-28 23:11 ` Tim Harvey
2023-02-28 23:11   ` Tim Harvey
2023-02-28 23:22   ` Marc Zyngier
2023-02-28 23:22     ` Marc Zyngier
2023-03-01 16:12     ` Robin Murphy
2023-03-01 16:12       ` Robin Murphy
2023-03-01 16:24       ` Marc Zyngier [this message]
2023-03-01 16:24         ` Marc Zyngier
2023-03-01 17:29       ` Tim Harvey
2023-03-01 17:29         ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k000l9so.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alcooperx@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tharvey@gateworks.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.