All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <chris@printf.net>
To: Dong Aisheng <b29396@freescale.com>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	shawn.guo@linaro.org, s.hauer@pengutronix.de
Subject: Re: [PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context
Date: Mon, 13 Jan 2014 18:41:59 +0000	[thread overview]
Message-ID: <86k3e3afm0.fsf@void.printf.net> (raw)
In-Reply-To: <1388042634-17281-1-git-send-email-b29396@freescale.com> (Dong Aisheng's message of "Thu, 26 Dec 2013 15:23:53 +0800")

Hi,

On Thu, Dec 26 2013, Dong Aisheng wrote:
> Sometimes we may meet the following lockdep issue.
> The root cause is .set_clock callback is executed with spin_lock_irqsave
> in sdhci_do_set_ios. However, the IMX set_clock callback will try to access
> clk_get_rate which is using a mutex lock.
>
> The fix avoids access mutex in .set_clock callback by initializing the
> pltfm_host->clock at probe time and use it later instead of calling
> clk_get_rate again in atomic context.
>
> [ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]

Thanks, pushed to mmc-next.

- Chris.
-- 
Chris Ball   <chris@printf.net>   <http://printf.net/>

WARNING: multiple messages have this Message-ID (diff)
From: chris@printf.net (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context
Date: Mon, 13 Jan 2014 18:41:59 +0000	[thread overview]
Message-ID: <86k3e3afm0.fsf@void.printf.net> (raw)
In-Reply-To: <1388042634-17281-1-git-send-email-b29396@freescale.com> (Dong Aisheng's message of "Thu, 26 Dec 2013 15:23:53 +0800")

Hi,

On Thu, Dec 26 2013, Dong Aisheng wrote:
> Sometimes we may meet the following lockdep issue.
> The root cause is .set_clock callback is executed with spin_lock_irqsave
> in sdhci_do_set_ios. However, the IMX set_clock callback will try to access
> clk_get_rate which is using a mutex lock.
>
> The fix avoids access mutex in .set_clock callback by initializing the
> pltfm_host->clock at probe time and use it later instead of calling
> clk_get_rate again in atomic context.
>
> [ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]

Thanks, pushed to mmc-next.

- Chris.
-- 
Chris Ball   <chris@printf.net>   <http://printf.net/>

  parent reply	other threads:[~2014-01-13 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-26  7:23 [PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context Dong Aisheng
2013-12-26  7:23 ` Dong Aisheng
2013-12-26  7:23 ` [PATCH V2 2/2] mmc: sdhci-esdhc-imx: fix warning during module remove function Dong Aisheng
2013-12-26  7:23   ` Dong Aisheng
2014-01-13 18:40   ` Chris Ball
2014-01-13 18:40     ` Chris Ball
2013-12-31  5:24 ` [PATCH V2 1/2] mmc: sdhci-esdhc-imx: fix access hardirq-unsafe lock in atomic context Shawn Guo
2013-12-31  5:24   ` Shawn Guo
2014-01-13 10:52   ` Dong Aisheng
2014-01-13 10:52     ` Dong Aisheng
2014-01-13 18:41 ` Chris Ball [this message]
2014-01-13 18:41   ` Chris Ball
2014-01-22 17:09 ` [PATCH " Ed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k3e3afm0.fsf@void.printf.net \
    --to=chris@printf.net \
    --cc=b29396@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.