All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev,
	linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v1 0/2] small kern_hyp_va() cleanups
Date: Thu, 08 Feb 2024 12:38:43 +0000	[thread overview]
Message-ID: <86le7v5dws.wl-maz@kernel.org> (raw)
In-Reply-To: <20240208105422.3444159-1-joey.gouly@arm.com>

On Thu, 08 Feb 2024 10:54:20 +0000,
Joey Gouly <joey.gouly@arm.com> wrote:
> 
> Hello,
> 
> I wanted to add some comments to __kern_hyp_va(), since I was recently trying
> to understand it, and I think it could be helpful for someone looking at it in
> the future.
> 
> The second patch removes the assembly macro version, since it is unused. Maybe
> (out-of-tree) pkvm uses it or it's just worth keeping around in case someone
> needs it in the future. So if that patch isn't applied it's not too important.

I checked with Fuad, and he confirmed that there is no assembly code
using kern_hyp_va() left in pKVM either, so this guys is definitely a
goner.

For the series,

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev,
	linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v1 0/2] small kern_hyp_va() cleanups
Date: Thu, 08 Feb 2024 12:38:43 +0000	[thread overview]
Message-ID: <86le7v5dws.wl-maz@kernel.org> (raw)
In-Reply-To: <20240208105422.3444159-1-joey.gouly@arm.com>

On Thu, 08 Feb 2024 10:54:20 +0000,
Joey Gouly <joey.gouly@arm.com> wrote:
> 
> Hello,
> 
> I wanted to add some comments to __kern_hyp_va(), since I was recently trying
> to understand it, and I think it could be helpful for someone looking at it in
> the future.
> 
> The second patch removes the assembly macro version, since it is unused. Maybe
> (out-of-tree) pkvm uses it or it's just worth keeping around in case someone
> needs it in the future. So if that patch isn't applied it's not too important.

I checked with Fuad, and he confirmed that there is no assembly code
using kern_hyp_va() left in pKVM either, so this guys is definitely a
goner.

For the series,

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-02-08 12:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 10:54 [PATCH v1 0/2] small kern_hyp_va() cleanups Joey Gouly
2024-02-08 10:54 ` Joey Gouly
2024-02-08 10:54 ` [PATCH v1 1/2] KVM: arm64: add comments to __kern_hyp_va Joey Gouly
2024-02-08 10:54   ` Joey Gouly
2024-02-08 10:54 ` [PATCH v1 2/2] KVM: arm64: removed unused kern_hyp_va asm macro Joey Gouly
2024-02-08 10:54   ` Joey Gouly
2024-02-08 12:42   ` Marc Zyngier
2024-02-08 12:42     ` Marc Zyngier
2024-02-08 13:28     ` Oliver Upton
2024-02-08 13:28       ` Oliver Upton
2024-02-08 11:22 ` [PATCH v1 0/2] small kern_hyp_va() cleanups Oliver Upton
2024-02-08 11:22   ` Oliver Upton
2024-02-08 12:38 ` Marc Zyngier [this message]
2024-02-08 12:38   ` Marc Zyngier
2024-02-12 20:55 ` Oliver Upton
2024-02-12 20:55   ` Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le7v5dws.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.