All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS
Date: Sun, 16 Nov 2014 12:59:09 +0000	[thread overview]
Message-ID: <86ppcn8foi.fsf@arm.com> (raw)
In-Reply-To: <1416136742.25454.4.camel@hellion.org.uk> (Ian Campbell's message of "Sun, 16 Nov 2014 11:19:02 +0000")

On Sun, Nov 16 2014 at 11:19:02 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> On Fri, 2014-10-24 at 20:28 +0200, Hans de Goede wrote:
>> It is not used anywhere.
>
> Might this be an oversight because sunxi is the only SoC with psci
> support so far? Marc, was this added intentionally with a usecase in
> mind or just a left over from an earlier version of the code?
>
> That said, I'd have expected that an NR_CPUS type setting would want to
> be part of the relevant PSCI backend, i.e. it would be more SoC
> specific.

This was in preparation of a possible reuse of that code for A31 and co,
but it should indeed be SoC specific. So thumb up for removal.

Thanks,

	M.

>> 
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  include/configs/sun7i.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
>> index 966cbd8..7f7369c 100644
>> --- a/include/configs/sun7i.h
>> +++ b/include/configs/sun7i.h
>> @@ -33,7 +33,6 @@
>>  #define CONFIG_ARMV7_VIRT		1
>>  #define CONFIG_ARMV7_NONSEC		1
>>  #define CONFIG_ARMV7_PSCI		1
>> -#define CONFIG_ARMV7_PSCI_NR_CPUS	2
>>  #define CONFIG_ARMV7_SECURE_BASE	SUNXI_SRAM_B_BASE
>>  #define CONFIG_SYS_CLK_FREQ		24000000
>>  
>
>
>

-- 
Jazz is not dead. It just smells funny.

  reply	other threads:[~2014-11-16 12:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 18:28 [U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS Hans de Goede
2014-11-16 11:19 ` Ian Campbell
2014-11-16 12:59   ` Marc Zyngier [this message]
2014-11-16 13:29     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ppcn8foi.fsf@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.