[U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS

[U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS

[Hans de Goede]

It is not used anywhere.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 include/configs/sun7i.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
index 966cbd8..7f7369c 100644
--- a/include/configs/sun7i.h
+++ b/include/configs/sun7i.h
@@ -33,7 +33,6 @@
 #define CONFIG_ARMV7_VIRT		1
 #define CONFIG_ARMV7_NONSEC		1
 #define CONFIG_ARMV7_PSCI		1
-#define CONFIG_ARMV7_PSCI_NR_CPUS	2
 #define CONFIG_ARMV7_SECURE_BASE	SUNXI_SRAM_B_BASE
 #define CONFIG_SYS_CLK_FREQ		24000000
 
-- 
2.1.0

[U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS

[Ian Campbell]

On Fri, 2014-10-24 at 20:28 +0200, Hans de Goede wrote:
> It is not used anywhere.

Might this be an oversight because sunxi is the only SoC with psci
support so far? Marc, was this added intentionally with a usecase in
mind or just a left over from an earlier version of the code?

That said, I'd have expected that an NR_CPUS type setting would want to
be part of the relevant PSCI backend, i.e. it would be more SoC
specific.

> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  include/configs/sun7i.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
> index 966cbd8..7f7369c 100644
> --- a/include/configs/sun7i.h
> +++ b/include/configs/sun7i.h
> @@ -33,7 +33,6 @@
>  #define CONFIG_ARMV7_VIRT		1
>  #define CONFIG_ARMV7_NONSEC		1
>  #define CONFIG_ARMV7_PSCI		1
> -#define CONFIG_ARMV7_PSCI_NR_CPUS	2
>  #define CONFIG_ARMV7_SECURE_BASE	SUNXI_SRAM_B_BASE
>  #define CONFIG_SYS_CLK_FREQ		24000000
>  

[U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS

[Marc Zyngier]

On Sun, Nov 16 2014 at 11:19:02 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> On Fri, 2014-10-24 at 20:28 +0200, Hans de Goede wrote:
>> It is not used anywhere.
>
> Might this be an oversight because sunxi is the only SoC with psci
> support so far? Marc, was this added intentionally with a usecase in
> mind or just a left over from an earlier version of the code?
>
> That said, I'd have expected that an NR_CPUS type setting would want to
> be part of the relevant PSCI backend, i.e. it would be more SoC
> specific.

This was in preparation of a possible reuse of that code for A31 and co,
but it should indeed be SoC specific. So thumb up for removal.

Thanks,

	M.

>> 
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  include/configs/sun7i.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
>> index 966cbd8..7f7369c 100644
>> --- a/include/configs/sun7i.h
>> +++ b/include/configs/sun7i.h
>> @@ -33,7 +33,6 @@
>>  #define CONFIG_ARMV7_VIRT		1
>>  #define CONFIG_ARMV7_NONSEC		1
>>  #define CONFIG_ARMV7_PSCI		1
>> -#define CONFIG_ARMV7_PSCI_NR_CPUS	2
>>  #define CONFIG_ARMV7_SECURE_BASE	SUNXI_SRAM_B_BASE
>>  #define CONFIG_SYS_CLK_FREQ		24000000
>>  
>
>
>

-- 
Jazz is not dead. It just smells funny.

[U-Boot] [PATCH] sun7i: Drop CONFIG_ARMV7_PSCI_NR_CPUS

[Ian Campbell]

On Sun, 2014-11-16 at 12:59 +0000, Marc Zyngier wrote:
> On Sun, Nov 16 2014 at 11:19:02 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> > On Fri, 2014-10-24 at 20:28 +0200, Hans de Goede wrote:
> >> It is not used anywhere.
> >
> > Might this be an oversight because sunxi is the only SoC with psci
> > support so far? Marc, was this added intentionally with a usecase in
> > mind or just a left over from an earlier version of the code?
> >
> > That said, I'd have expected that an NR_CPUS type setting would want to
> > be part of the relevant PSCI backend, i.e. it would be more SoC
> > specific.
> 
> This was in preparation of a possible reuse of that code for A31 and co,
> but it should indeed be SoC specific. So thumb up for removal.

Thanks, in which case:

Acked-by: Ian Campbell <ijc@hellion.org.uk>