[linux-next:master 7083/12380] include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_845' declared with attribute error: BUILD_BUG_ON failed: !__builtin_constant_p(sr)

[linux-next:master 7083/12380] include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_845' declared with attribute error: BUILD_BUG_ON failed: !__builtin_constant_p(sr)

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   ac24e26aa08fe026804f678599f805eb13374a5d
commit: a0162020095e2a34a59fc64c07183cc039e759f6 [7083/12380] KVM: arm64: Extend masking facility to arbitrary registers
config: arm64-randconfig-004-20241120 (https://download.01.org/0day-ci/archive/20241120/202411201857.ZNudtGJl-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201857.ZNudtGJl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411201857.ZNudtGJl-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from <command-line>:
   arch/arm64/kvm/nested.c: In function 'set_sysreg_masks':
>> include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_845' declared with attribute error: BUILD_BUG_ON failed: !__builtin_constant_p(sr)
     517 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |                                             ^
   include/linux/compiler_types.h:498:25: note: in definition of macro '__compiletime_assert'
     498 |                         prefix ## suffix();                             \
         |                         ^~~~~~
   include/linux/compiler_types.h:517:9: note: in expansion of macro '_compiletime_assert'
     517 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^~~~~~~~~~~~~~~~
   arch/arm64/kvm/nested.c:957:9: note: in expansion of macro 'BUILD_BUG_ON'
     957 |         BUILD_BUG_ON(!__builtin_constant_p(sr));
         |         ^~~~~~~~~~~~


vim +/__compiletime_assert_845 +517 include/linux/compiler_types.h

eb5c2d4b45e3d2 Will Deacon 2020-07-21  503  
eb5c2d4b45e3d2 Will Deacon 2020-07-21  504  #define _compiletime_assert(condition, msg, prefix, suffix) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21  505  	__compiletime_assert(condition, msg, prefix, suffix)
eb5c2d4b45e3d2 Will Deacon 2020-07-21  506  
eb5c2d4b45e3d2 Will Deacon 2020-07-21  507  /**
eb5c2d4b45e3d2 Will Deacon 2020-07-21  508   * compiletime_assert - break build and emit msg if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21  509   * @condition: a compile-time constant condition to check
eb5c2d4b45e3d2 Will Deacon 2020-07-21  510   * @msg:       a message to emit if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21  511   *
eb5c2d4b45e3d2 Will Deacon 2020-07-21  512   * In tradition of POSIX assert, this macro will break the build if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21  513   * supplied condition is *false*, emitting the supplied error message if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21  514   * compiler has support to do so.
eb5c2d4b45e3d2 Will Deacon 2020-07-21  515   */
eb5c2d4b45e3d2 Will Deacon 2020-07-21  516  #define compiletime_assert(condition, msg) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 @517  	_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
eb5c2d4b45e3d2 Will Deacon 2020-07-21  518  

:::::: The code at line 517 was first introduced by commit
:::::: eb5c2d4b45e3d2d5d052ea6b8f1463976b1020d5 compiler.h: Move compiletime_assert() macros into compiler_types.h

:::::: TO: Will Deacon <will@kernel.org>
:::::: CC: Will Deacon <will@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [linux-next:master 7083/12380] include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_845' declared with attribute error: BUILD_BUG_ON failed: !__builtin_constant_p(sr)

[Marc Zyngier]

On Wed, 20 Nov 2024 10:09:36 +0000,
kernel test robot <lkp@intel.com> wrote:
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   ac24e26aa08fe026804f678599f805eb13374a5d
> commit: a0162020095e2a34a59fc64c07183cc039e759f6 [7083/12380] KVM: arm64: Extend masking facility to arbitrary registers
> config: arm64-randconfig-004-20241120 (https://download.01.org/0day-ci/archive/20241120/202411201857.ZNudtGJl-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201857.ZNudtGJl-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202411201857.ZNudtGJl-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from <command-line>:
>    arch/arm64/kvm/nested.c: In function 'set_sysreg_masks':
> >> include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_845' declared with attribute error: BUILD_BUG_ON failed: !__builtin_constant_p(sr)

That's annoying. CONFIG_CC_OPTIMIZE_FOR_SIZE=y is what generates the
(legitimate) breakage. The hack below addresses it.

	M.

diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
index aeaa6017ffd89..9b36218b48def 100644
--- a/arch/arm64/kvm/nested.c
+++ b/arch/arm64/kvm/nested.c
@@ -951,7 +951,7 @@ u64 kvm_vcpu_apply_reg_masks(const struct kvm_vcpu *vcpu,
 	return v;
 }
 
-static void set_sysreg_masks(struct kvm *kvm, int sr, u64 res0, u64 res1)
+static __always_inline void set_sysreg_masks(struct kvm *kvm, int sr, u64 res0, u64 res1)
 {
 	int i = sr - __SANITISED_REG_START__;
 

-- 
Without deviation from the norm, progress is not possible.