All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Alan Coopersmith <alan.coopersmith@oracle.com>
Cc: mesa-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Mark drmServerInfo.debug_print with printf attribute
Date: Wed, 11 Dec 2013 22:42:00 -0800	[thread overview]
Message-ID: <86sityzi2v.fsf@miki.keithp.com> (raw)
In-Reply-To: <52A9351C.3090802@oracle.com>


[-- Attachment #1.1: Type: text/plain, Size: 706 bytes --]

Alan Coopersmith <alan.coopersmith@oracle.com> writes:

> You should drop that line - those comments are used for us to figure out which
> xproto version to list in the pkg-config requirements when using newer _X_* 
> macros out of Xfuncproto.h, so doesn't make sense here.
>
> Also be warned that using a macro name starting with an _ will cause you to get
> complaints about violating the "reserved for the implementation" rule in the
> ANSI/ISO C standards from people who consider the implementation to solely be
> the compiler, not the OS.  https://bugs.freedesktop.org/show_bug.cgi?id=70686
> for example.

Thanks for the suggestions; both easy to adopt.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 156 bytes --]

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

      reply	other threads:[~2013-12-12  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 21:17 [PATCH] Mark drmServerInfo.debug_print with printf attribute Keith Packard
2013-12-12  4:01 ` Alan Coopersmith
2013-12-12  6:42   ` Keith Packard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sityzi2v.fsf@miki.keithp.com \
    --to=keithp@keithp.com \
    --cc=alan.coopersmith@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mesa-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.