From: Marc Zyngier <maz@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Huacai Chen" <chenhuacai@loongson.cn>,
"Thomas Gleixner" <tglx@linutronix.de>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
"Xuefeng Li" <lixuefeng@loongson.cn>,
"Huacai Chen" <chenhuacai@gmail.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems
Date: Tue, 27 Sep 2022 07:37:07 -0400 [thread overview]
Message-ID: <86tu4t6obg.wl-maz@kernel.org> (raw)
In-Reply-To: <e0efb8a9-b4b0-47bf-ab84-ea71c3630f9d@www.fastmail.com>
On Tue, 27 Sep 2022 03:51:04 -0400,
"Arnd Bergmann" <arnd@arndb.de> wrote:
>
> On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
>
> > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> >
> > void __init irqchip_init(void)
> > {
> > +#ifdef CONFIG_OF_IRQ
> > of_irq_init(__irqchip_of_table);
> > +#endif
> > acpi_probe_device_table(irqchip);
> > }
>
> I think that #ifdef should be in the include/linux/of_irq.h
> header, with an empty inline function in the #else path.
Agreed. Please keep the C code free of #ifdefs if at all possible.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-09-27 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 4:55 [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems Huacai Chen
2022-09-27 7:51 ` Arnd Bergmann
2022-09-27 11:37 ` Marc Zyngier [this message]
2022-09-27 12:32 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tu4t6obg.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.