All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
To: Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, lin
Cc: vamos-dev@i4.informatik.uni-erlangen.de
Subject: Missing config option for SFFSDR_FPGA
Date: Wed, 21 Jul 2010 12:58:33 +0200	[thread overview]
Message-ID: <86tynthzja.fsf@peer.zerties.org> (raw)

Hi all!
       
        As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux'
configuration system.

        I've been running a check on the sound/ sourcetree for
config Items not defined in Kconfig and found such a case. Sourcecode
blocks depending on these Items are not reachable from a vanilla
kernel -- dead code. I've seen such dead blocks made on purpose
e.g. while integrating new features into the kernel but generally
they're just useless.

There are two ifdef blocks, which do a check on CONFIG_SFFSDR_FPGA, but
this flag isn't defined anywhere. There is an select in
sound/soc/davinci[1], but Kconfig doesn't define the symbol, if there
isn't a config option for it. So this blocks can never be selected. I
don't think this is intended, so i didn't wrote a patch. Please just
notice it.

Regards
        Christian Dietrich

[0] http://vamos1.informatik.uni-erlangen.de/
[1] sound/soc/davinci/Kconfig:      select SFFSDR_FPGA                 
    sound/soc/davinci/davinci-sffsdr.c:#ifdef CONFIG_SFFSDR_FPGA
    sound/soc/davinci/davinci-sffsdr.c:#ifndef CONFIG_SFFSDR_FPGA
    sound/soc/davinci/davinci-sffsdr.c:#ifndef CONFIG_SFFSDR_FPGA
-- 
(λ x . x x) (λ x . x x) -- See how beatiful the lambda is
No documentation is better than bad documentation
-- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.

WARNING: multiple messages have this Message-ID (diff)
From: Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
To: Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: vamos-dev@i4.informatik.uni-erlangen.de
Subject: Missing config option for SFFSDR_FPGA
Date: Wed, 21 Jul 2010 12:58:33 +0200	[thread overview]
Message-ID: <86tynthzja.fsf@peer.zerties.org> (raw)

Hi all!
       
        As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux'
configuration system.

        I've been running a check on the sound/ sourcetree for
config Items not defined in Kconfig and found such a case. Sourcecode
blocks depending on these Items are not reachable from a vanilla
kernel -- dead code. I've seen such dead blocks made on purpose
e.g. while integrating new features into the kernel but generally
they're just useless.

There are two ifdef blocks, which do a check on CONFIG_SFFSDR_FPGA, but
this flag isn't defined anywhere. There is an select in
sound/soc/davinci[1], but Kconfig doesn't define the symbol, if there
isn't a config option for it. So this blocks can never be selected. I
don't think this is intended, so i didn't wrote a patch. Please just
notice it.

Regards
        Christian Dietrich

[0] http://vamos1.informatik.uni-erlangen.de/
[1] sound/soc/davinci/Kconfig:      select SFFSDR_FPGA                 
    sound/soc/davinci/davinci-sffsdr.c:#ifdef CONFIG_SFFSDR_FPGA
    sound/soc/davinci/davinci-sffsdr.c:#ifndef CONFIG_SFFSDR_FPGA
    sound/soc/davinci/davinci-sffsdr.c:#ifndef CONFIG_SFFSDR_FPGA
-- 
(λ x . x x) (λ x . x x) -- See how beatiful the lambda is
No documentation is better than bad documentation
-- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt.

             reply	other threads:[~2010-07-21 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21 10:58 Christian Dietrich [this message]
2010-07-21 10:58 ` Missing config option for SFFSDR_FPGA Christian Dietrich
2010-07-21 12:28 ` Mark Brown
2010-07-21 12:28   ` Mark Brown
2010-07-21 12:34   ` Takashi Iwai
2010-07-21 12:34     ` Takashi Iwai
2010-07-21 12:55     ` Mark Brown
2010-07-21 12:55       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tynthzja.fsf@peer.zerties.org \
    --to=qy03fugy@stud.informatik.uni-erlangen.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=vamos-dev@i4.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.