From: Marc Zyngier <maz@kernel.org>
To: Dawei Li <dawei.li@shingroup.cn>
Cc: tglx@linutronix.de, yury.norov@gmail.com, rafael@kernel.org,
akpm@linux-foundation.org, florian.fainelli@broadcom.com,
chenhuacai@kernel.org, jiaxun.yang@flygoat.com,
anup@brainfault.org, palmer@dabbelt.com,
samuel.holland@sifive.com, linux@rasmusvillemoes.dk,
daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack
Date: Wed, 17 Apr 2024 11:56:07 +0100 [thread overview]
Message-ID: <86v84gqmuw.wl-maz@kernel.org> (raw)
In-Reply-To: <20240416085454.3547175-4-dawei.li@shingroup.cn>
On Tue, 16 Apr 2024 09:54:50 +0100,
Dawei Li <dawei.li@shingroup.cn> wrote:
>
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
>
> Remove cpumask var on stack and use cpumask_any_and() to address it.
>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-04-17 10:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 8:54 [PATCH v2 0/7] Remove on-stack cpumask var for irq subsystem Dawei Li
2024-04-16 8:54 ` [PATCH v2 1/7] cpumask: introduce cpumask_first_and_and() Dawei Li
2024-04-16 17:45 ` Yury Norov
2024-04-16 17:49 ` Yury Norov
2024-04-17 1:35 ` Dawei Li
2024-04-24 20:04 ` [tip: irq/core] cpumask: Introduce cpumask_first_and_and() tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 2/7] irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 3/7] irqchip/gic-v3-its: " Dawei Li
2024-04-17 10:56 ` Marc Zyngier [this message]
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 4/7] irqchip/loongson-eiointc: " Dawei Li
2024-04-16 18:01 ` Yury Norov
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 5/7] irqchip/riscv-aplic-direct: " Dawei Li
2024-04-17 11:22 ` Anup Patel
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 6/7] irqchip/sifive-plic: " Dawei Li
2024-04-17 11:21 ` Anup Patel
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
2024-04-16 8:54 ` [PATCH v2 7/7] cpuidle: " Dawei Li
2024-04-24 20:04 ` [tip: irq/core] " tip-bot2 for Dawei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v84gqmuw.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anup@brainfault.org \
--cc=chenhuacai@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dawei.li@shingroup.cn \
--cc=florian.fainelli@broadcom.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=palmer@dabbelt.com \
--cc=rafael@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=tglx@linutronix.de \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.