Re: [PATCH 1/1 v2] mmc_utils: add ffu support

[Chris Ball <chris@printf.net>]

Hi,

On Fri, Feb 26 2016, Chris Ball wrote:
> Thanks for resending.  I'm getting some compile errors, any ideas?
>
> mmc_cmds.c: In function ‘do_ffu’:
> mmc_cmds.c:2076:31: error: invalid application of ‘sizeof’ to incomplete type ‘struct mmc_ioc_multi_cmd’
>   multi_cmd = calloc(1, sizeof(struct mmc_ioc_multi_cmd) +
>                                ^
>
> mmc_cmds.c:2126:11: error: dereferencing pointer to incomplete type ‘struct mmc_ioc_multi_cmd’
>   multi_cmd->num_of_cmds = 3;
>            ^
>
> mmc_cmds.c:2162:23: error: ‘MMC_IOC_MULTI_CMD’ undeclared (first use in this function)
>    ret = ioctl(dev_fd, MMC_IOC_MULTI_CMD, multi_cmd);
>                        ^

Oh, I bet it's because we include <linux/mmc/ioctl.h>, and now that
needs to be coming from Linux 4.4+ to include the new ioctl.

Putting a compile-dependency on Linux 4.4+ seems very tough, though.
mmc-utils is built on many distributions (e.g. Debian repository build
machines, ChromeOS build machines) where it may not be possible to
upgrade the system kernel headers.

Please could we get some #ifdefs on MMC_IOC_MULTI_CMD around the
FFU code?

Thanks!

- Chris.
-- 
Chris Ball   <http://printf.net/>