Re: [PATCH 1/1 v2] mmc_utils: add ffu support

[Chris Ball <chris@printf.net>]

Hi Avi,

On Tue, Feb 23 2016, Avi Shchislowski wrote:
> Adding support for field firmware update over multiple command ioctl.
> As multiple command ioctl is supported only from kernel 4.4, this patch should be used against kernel 4.4 and above.
>
> Known issues:
> - There is no support for Multiple Block write commands (CMD25) in existing 
>    IOCTL implementation
> - In case MODE_OPERATION_CODES field is not supported by the device
>    manual reset of the device/platform is required.
>    The reset issue discussed in another email thread - " [RFC 0/6] mmc: Field Firmware Update"
>
> Change since v1:
> - modified copyright header
>
> Signed-off-by: Yaniv Agman <yaniv.agman@sandisk.com>
> Signed-off-by: Avi Shchislowski <avi.shchislowski@sandisk.com>

Thanks for resending.  I'm getting some compile errors, any ideas?

mmc_cmds.c: In function ‘do_ffu’:
mmc_cmds.c:2076:31: error: invalid application of ‘sizeof’ to incomplete type ‘struct mmc_ioc_multi_cmd’
  multi_cmd = calloc(1, sizeof(struct mmc_ioc_multi_cmd) +
                               ^

mmc_cmds.c:2126:11: error: dereferencing pointer to incomplete type ‘struct mmc_ioc_multi_cmd’
  multi_cmd->num_of_cmds = 3;
           ^

mmc_cmds.c:2162:23: error: ‘MMC_IOC_MULTI_CMD’ undeclared (first use in this function)
   ret = ioctl(dev_fd, MMC_IOC_MULTI_CMD, multi_cmd);
                       ^

- Chris.
-- 
Chris Ball   <http://printf.net/>