From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, stable@kernel.org
Subject: Re: [PATCH] drm/i915: enable vdd when switching off the eDP panel
Date: Mon, 21 May 2012 18:49:18 -0700 [thread overview]
Message-ID: <86vcjphtnl.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20120521164030.GB4970@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1154,11 +1154,10 @@ static void ironlake_edp_panel_off(struct intel_dp *intel_dp)
>>
>> DRM_DEBUG_KMS("Turn eDP power off\n");
>>
>> - WARN(intel_dp->want_panel_vdd, "Cannot turn power off while VDD is on\n");
>> - ironlake_panel_vdd_off_sync(intel_dp); /* finish any pending work */
>> + WARN(!intel_dp->want_panel_vdd, "Need VDD to turn off panel\n");
>>
>> pp = ironlake_get_pp_control(dev_priv);
>> - pp &= ~(POWER_TARGET_ON | EDP_FORCE_VDD | PANEL_POWER_RESET | EDP_BLC_ENABLE);
>> + pp &= ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_BLC_ENABLE);
Can you explain where the panel is getting turned off here?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-05-22 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 15:14 [PATCH] drm/i915: enable vdd when switching off the eDP panel Daniel Vetter
2012-05-21 16:40 ` Daniel Vetter
2012-05-21 19:09 ` Chris Wilson
2012-05-22 1:49 ` Keith Packard [this message]
2012-05-22 6:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86vcjphtnl.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.