All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org,
	Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default
Date: Tue, 14 Feb 2012 17:01:30 +1300	[thread overview]
Message-ID: <86vcnaqd0l.fsf@sumi.keithp.com> (raw)
In-Reply-To: <CAC7Lmnu+0yULBkv_Z2Bq4aqzGzzi-cDRtZaGLLZxHEGZpDYFeg@mail.gmail.com>

<#part sign=pgpmime>
On Sun, 12 Feb 2012 22:34:48 -0200, Eugeni Dodonov <eugeni@dodonov.net> wrote:

> what if we pick only the 1st patch in this series for -fixes? It won't
> change the defaults in any way, but it will allow the ones willing to
> enable it manually on SNB to prevent issues.

That seems like too big a change at this point in the release cycle. We
should be focused purely on fixing functionality bugs, not adding new
features. So, instead of adding the ability to individually control RC6
levels, we should just change what RC6 does on SNB when it is enabled,
then encourage people to test that and see if the shallowest RC6 states
actually work. That will provide sufficient information to know whether
it will be safe to turn that on by default in the next release, which is
what we really want.

The smallest change that gives us the data we need is what I'd like to have.

-- 
keith.packard@intel.com

  reply	other threads:[~2012-02-14  4:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-11 12:34 [PATCH 0/2] Another chapter in RC6 saga Eugeni Dodonov
2012-02-11 12:34 ` [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter Eugeni Dodonov
2012-02-11 12:56   ` Chris Wilson
2012-02-11 18:13     ` Kai Krakow
2012-02-11 19:09       ` Eugeni Dodonov
2012-02-11 19:23     ` [PATCH 1/1] " Eugeni Dodonov
2012-02-11 19:57       ` Chris Wilson
2012-02-12 20:52       ` Ben Widawsky
2012-02-12 23:16         ` Eugeni Dodonov
2012-02-13  8:33           ` Ben Widawsky
2012-02-13 11:37             ` Eugeni Dodonov
2012-02-11 12:34 ` [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default Eugeni Dodonov
2012-02-11 12:59   ` Chris Wilson
2012-02-11 19:24     ` Eugeni Dodonov
2012-02-12 10:16       ` Kai Krakow
2012-02-12 20:10       ` Keith Packard
2012-02-13  0:34         ` Eugeni Dodonov
2012-02-14  4:01           ` Keith Packard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-02-11 20:26 Luigi Forte
2012-03-23 14:57 [PATCH 0/2] RC6 changes for 3.4 got missing Eugeni Dodonov
2012-03-23 14:57 ` [PATCH 2/2] drm/i915: enable plain RC6 on Sandy Bridge by default Eugeni Dodonov
2012-03-23 15:06   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86vcnaqd0l.fsf@sumi.keithp.com \
    --to=keithp@keithp.com \
    --cc=eugeni.dodonov@intel.com \
    --cc=eugeni@dodonov.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.