All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Miguel Luis <miguel.luis@oracle.com>
Cc: "kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Chase Conklin <chase.conklin@arm.com>,
	Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
	Darren Hart <darren@os.amperecomputing.com>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v3 15/27] KVM: arm64: nv: Add trap forwarding for HCR_EL2
Date: Tue, 15 Aug 2023 17:09:23 +0100	[thread overview]
Message-ID: <86wmxwfft8.wl-maz@kernel.org> (raw)
In-Reply-To: <0A8ED162-EF6C-44F4-836B-7421183EA9A0@oracle.com>

On Tue, 15 Aug 2023 16:46:21 +0100,
Miguel Luis <miguel.luis@oracle.com> wrote:
> 
> > + [CGT_HCR_FIEN] = {
> > + .index = HCR_EL2,
> > + .value = HCR_FIEN,
> 
> Should this value be 0 ?

Indeed. I've renamed the trap to be CGT_HCR_nFIEN, and set the value
to 0.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Miguel Luis <miguel.luis@oracle.com>
Cc: "kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Chase Conklin <chase.conklin@arm.com>,
	Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
	Darren Hart <darren@os.amperecomputing.com>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v3 15/27] KVM: arm64: nv: Add trap forwarding for HCR_EL2
Date: Tue, 15 Aug 2023 17:09:23 +0100	[thread overview]
Message-ID: <86wmxwfft8.wl-maz@kernel.org> (raw)
In-Reply-To: <0A8ED162-EF6C-44F4-836B-7421183EA9A0@oracle.com>

On Tue, 15 Aug 2023 16:46:21 +0100,
Miguel Luis <miguel.luis@oracle.com> wrote:
> 
> > + [CGT_HCR_FIEN] = {
> > + .index = HCR_EL2,
> > + .value = HCR_FIEN,
> 
> Should this value be 0 ?

Indeed. I've renamed the trap to be CGT_HCR_nFIEN, and set the value
to 0.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-15 16:09 UTC|newest]

Thread overview: 140+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 11:46 [PATCH v3 00/27] KVM: arm64: NV trap forwarding infrastructure Marc Zyngier
2023-08-08 11:46 ` Marc Zyngier
2023-08-08 11:46 ` [PATCH v3 01/27] arm64: Add missing VA CMO encodings Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-10  3:14   ` Jing Zhang
2023-08-10  3:14     ` Jing Zhang
2023-08-15 10:39     ` Marc Zyngier
2023-08-15 10:39       ` Marc Zyngier
2023-08-08 11:46 ` [PATCH v3 02/27] arm64: Add missing ERX*_EL1 encodings Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-10  4:25   ` Jing Zhang
2023-08-10  4:25     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 03/27] arm64: Add missing DC ZVA/GVA/GZVA encodings Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-10  4:29   ` Jing Zhang
2023-08-10  4:29     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 04/27] arm64: Add TLBI operation encodings Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-10  5:22   ` Jing Zhang
2023-08-10  5:22     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 05/27] arm64: Add AT " Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11  2:20   ` Jing Zhang
2023-08-11  2:20     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 06/27] arm64: Add debug registers affected by HDFGxTR_EL2 Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11  3:00   ` Jing Zhang
2023-08-11  3:00     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 07/27] arm64: Add missing BRB/CFP/DVP/CPP instructions Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11  3:07   ` Jing Zhang
2023-08-11  3:07     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 08/27] arm64: Add HDFGRTR_EL2 and HDFGWTR_EL2 layouts Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11  3:19   ` Jing Zhang
2023-08-11  3:19     ` Jing Zhang
2023-08-14 12:32   ` Eric Auger
2023-08-14 12:32     ` Eric Auger
2023-08-08 11:46 ` [PATCH v3 09/27] arm64: Add feature detection for fine grained traps Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11 15:26   ` Jing Zhang
2023-08-11 15:26     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 10/27] KVM: arm64: Correctly handle ACCDATA_EL1 traps Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11 15:31   ` Jing Zhang
2023-08-11 15:31     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 11/27] KVM: arm64: Add missing HCR_EL2 trap bits Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11 16:21   ` Jing Zhang
2023-08-11 16:21     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 12/27] KVM: arm64: nv: Add FGT registers Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11 16:36   ` Jing Zhang
2023-08-11 16:36     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 13/27] KVM: arm64: Restructure FGT register switching Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-11 17:40   ` Jing Zhang
2023-08-11 17:40     ` Jing Zhang
2023-08-08 11:46 ` [PATCH v3 14/27] KVM: arm64: nv: Add trap forwarding infrastructure Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-09 13:27   ` Eric Auger
2023-08-09 13:27     ` Eric Auger
2023-08-10 14:44     ` Marc Zyngier
2023-08-10 14:44       ` Marc Zyngier
2023-08-10 17:34       ` Eric Auger
2023-08-10 17:34         ` Eric Auger
2023-08-09 18:28   ` Miguel Luis
2023-08-09 18:28     ` Miguel Luis
2023-08-10 14:43     ` Marc Zyngier
2023-08-10 14:43       ` Marc Zyngier
2023-08-13  2:24   ` Jing Zhang
2023-08-13  2:24     ` Jing Zhang
2023-08-15 10:38     ` Marc Zyngier
2023-08-15 10:38       ` Marc Zyngier
2023-08-08 11:46 ` [PATCH v3 15/27] KVM: arm64: nv: Add trap forwarding for HCR_EL2 Marc Zyngier
2023-08-08 11:46   ` Marc Zyngier
2023-08-12  3:08   ` Miguel Luis
2023-08-12  3:08     ` Miguel Luis
2023-08-15 10:39     ` Marc Zyngier
2023-08-15 10:39       ` Marc Zyngier
2023-08-15 15:35       ` Miguel Luis
2023-08-15 15:35         ` Miguel Luis
2023-08-15 16:07         ` Marc Zyngier
2023-08-15 16:07           ` Marc Zyngier
2023-08-15 15:46   ` Miguel Luis
2023-08-15 15:46     ` Miguel Luis
2023-08-15 16:09     ` Marc Zyngier [this message]
2023-08-15 16:09       ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 16/27] KVM: arm64: nv: Expose FEAT_EVT to nested guests Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-14 21:08   ` Jing Zhang
2023-08-14 21:08     ` Jing Zhang
2023-08-08 11:47 ` [PATCH v3 17/27] KVM: arm64: nv: Add trap forwarding for MDCR_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 18/27] KVM: arm64: nv: Add trap forwarding for CNTHCTL_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 19/27] KVM: arm64: nv: Add fine grained trap forwarding infrastructure Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-14 17:18   ` Jing Zhang
2023-08-14 17:18     ` Jing Zhang
2023-08-15 10:39     ` Marc Zyngier
2023-08-15 10:39       ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 20/27] KVM: arm64: nv: Add trap forwarding for HFGxTR_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 21/27] KVM: arm64: nv: Add trap forwarding for HFGITR_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-08 11:47 ` [PATCH v3 22/27] KVM: arm64: nv: Add trap forwarding for HDFGxTR_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-08 12:30   ` Eric Auger
2023-08-08 12:30     ` Eric Auger
2023-08-08 11:47 ` [PATCH v3 23/27] KVM: arm64: nv: Add SVC trap forwarding Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-10  8:35   ` Eric Auger
2023-08-10  8:35     ` Eric Auger
2023-08-10 10:42     ` Marc Zyngier
2023-08-10 10:42       ` Marc Zyngier
2023-08-10 17:30       ` Eric Auger
2023-08-10 17:30         ` Eric Auger
2023-08-11  7:36         ` Marc Zyngier
2023-08-11  7:36           ` Marc Zyngier
2023-08-14  9:37           ` Eric Auger
2023-08-14  9:37             ` Eric Auger
2023-08-14  9:37   ` Eric Auger
2023-08-14  9:37     ` Eric Auger
2023-08-08 11:47 ` [PATCH v3 24/27] KVM: arm64: nv: Add switching support for HFGxTR/HDFGxTR Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-10  8:59   ` Eric Auger
2023-08-10  8:59     ` Eric Auger
2023-08-08 11:47 ` [PATCH v3 25/27] KVM: arm64: nv: Expose FGT to nested guests Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-10  9:44   ` Eric Auger
2023-08-10  9:44     ` Eric Auger
2023-08-08 11:47 ` [PATCH v3 26/27] KVM: arm64: Move HCRX_EL2 switch to load/put on VHE systems Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-10 12:38   ` Eric Auger
2023-08-10 12:38     ` Eric Auger
2023-08-08 11:47 ` [PATCH v3 27/27] KVM: arm64: nv: Add support for HCRX_EL2 Marc Zyngier
2023-08-08 11:47   ` Marc Zyngier
2023-08-14 12:17   ` Eric Auger
2023-08-14 12:17     ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wmxwfft8.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=alexandru.elisei@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=chase.conklin@arm.com \
    --cc=darren@os.amperecomputing.com \
    --cc=eric.auger@redhat.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=james.morse@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=miguel.luis@oracle.com \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.