* drm/i915: remove ACPI related DRM_ERRORs
@ 2012-01-12 17:03 Jesse Barnes
2012-01-12 17:20 ` Keith Packard
2012-01-12 17:22 ` Adam Jackson
0 siblings, 2 replies; 5+ messages in thread
From: Jesse Barnes @ 2012-01-12 17:03 UTC (permalink / raw)
To: airlied, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 924 bytes --]
They're not really errors (well actually I don't know; I don't
understand _DSM and _MUX well enough to say, but I do know they spam
people's logs and seem to be harmless).
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c
index cb91210..01c671f 100644
--- a/drivers/gpu/drm/i915/intel_acpi.c
+++ b/drivers/gpu/drm/i915/intel_acpi.c
@@ -182,8 +182,6 @@ static void intel_dsm_platform_mux_info(void)
DRM_DEBUG_DRIVER(" hpd mux info: %s\n",
intel_dsm_mux_type(info->buffer.pointer[3]));
}
- } else {
- DRM_ERROR("MUX INFO call failed\n");
}
out:
@@ -208,7 +206,6 @@ static bool intel_dsm_pci_probe(struct pci_dev *pdev)
ret = intel_dsm(dhandle, INTEL_DSM_FN_SUPPORTED_FUNCTIONS, 0);
if (ret < 0) {
- DRM_ERROR("failed to get supported _DSM functions\n");
return false;
}
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: drm/i915: remove ACPI related DRM_ERRORs
2012-01-12 17:03 drm/i915: remove ACPI related DRM_ERRORs Jesse Barnes
@ 2012-01-12 17:20 ` Keith Packard
2012-01-12 17:21 ` Jesse Barnes
2012-01-12 17:22 ` Adam Jackson
1 sibling, 1 reply; 5+ messages in thread
From: Keith Packard @ 2012-01-12 17:20 UTC (permalink / raw)
To: Jesse Barnes, airlied, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]
On Thu, 12 Jan 2012 09:03:14 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> They're not really errors (well actually I don't know; I don't
> understand _DSM and _MUX well enough to say, but I do know they spam
> people's logs and seem to be harmless).
Maybe change them to DRM_DEBUG_DRIVER?
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drm/i915: remove ACPI related DRM_ERRORs
2012-01-12 17:20 ` Keith Packard
@ 2012-01-12 17:21 ` Jesse Barnes
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Barnes @ 2012-01-12 17:21 UTC (permalink / raw)
To: Keith Packard; +Cc: airlied, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 697 bytes --]
On Thu, 12 Jan 2012 09:20:20 -0800
Keith Packard <keithp@keithp.com> wrote:
> On Thu, 12 Jan 2012 09:03:14 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > They're not really errors (well actually I don't know; I don't
> > understand _DSM and _MUX well enough to say, but I do know they spam
> > people's logs and seem to be harmless).
>
> Maybe change them to DRM_DEBUG_DRIVER?
Thought about that, but I don't even know what these failures mean in
real life, so having debug output for them is also superfluous.
Maybe Matthew or Dave have ideas? AFAIK these bits are only for
switchable gfx configs anyway...
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drm/i915: remove ACPI related DRM_ERRORs
2012-01-12 17:03 drm/i915: remove ACPI related DRM_ERRORs Jesse Barnes
2012-01-12 17:20 ` Keith Packard
@ 2012-01-12 17:22 ` Adam Jackson
2012-01-16 20:13 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Adam Jackson @ 2012-01-12 17:22 UTC (permalink / raw)
To: Jesse Barnes; +Cc: airlied, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
On Thu, 2012-01-12 at 09:03 -0800, Jesse Barnes wrote:
> They're not really errors (well actually I don't know; I don't
> understand _DSM and _MUX well enough to say, but I do know they spam
> people's logs and seem to be harmless).
Looks familiar!
http://lists.freedesktop.org/archives/intel-gfx/2011-September/011994.html
http://lists.freedesktop.org/archives/intel-gfx/2011-October/012563.html
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: drm/i915: remove ACPI related DRM_ERRORs
2012-01-12 17:22 ` Adam Jackson
@ 2012-01-16 20:13 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2012-01-16 20:13 UTC (permalink / raw)
To: Adam Jackson; +Cc: airlied, intel-gfx
On Thu, Jan 12, 2012 at 12:22:37PM -0500, Adam Jackson wrote:
> On Thu, 2012-01-12 at 09:03 -0800, Jesse Barnes wrote:
> > They're not really errors (well actually I don't know; I don't
> > understand _DSM and _MUX well enough to say, but I do know they spam
> > people's logs and seem to be harmless).
>
> Looks familiar!
>
> http://lists.freedesktop.org/archives/intel-gfx/2011-September/011994.html
> http://lists.freedesktop.org/archives/intel-gfx/2011-October/012563.html
>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
I've picked up the old one ;-)
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-16 20:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 17:03 drm/i915: remove ACPI related DRM_ERRORs Jesse Barnes
2012-01-12 17:20 ` Keith Packard
2012-01-12 17:21 ` Jesse Barnes
2012-01-12 17:22 ` Adam Jackson
2012-01-16 20:13 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.