All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Arto Merilainen <amerilainen@nvidia.com>
Cc: Terje Bergstrom <tbergstrom@nvidia.com>,
	xorg-devel@lists.x.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value
Date: Tue, 28 May 2013 13:12:12 -0600	[thread overview]
Message-ID: <86y5ay6hrn.fsf@miki.keithp.com> (raw)
In-Reply-To: <20130528103927.GB11547@mithrandir>


[-- Attachment #1.1: Type: text/plain, Size: 589 bytes --]

Thierry Reding <thierry.reding@gmail.com> writes:


> That doesn't sound right. Maybe drmIoctl() needs fixing instead. Looking
> at the history, drmIoctl() was introduced to automatically loop if a
> signal was received (commit 8b9ab108ec1f2ba2b503f713769c4946849b3cb2).
> However the ioctl(3p) manpage doesn't mention that ioctl() returns
> EAGAIN in case it is interrupted by a signal.

EAGAIN is being returned when the GPU is wedged to ask the application
to re-submit the request, which will presumably be held until the  GPU
is un-wedged.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Keith Packard <keithp@keithp.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Arto Merilainen <amerilainen@nvidia.com>
Cc: "airlied\@linux.ie" <airlied@linux.ie>,
	"linux-tegra\@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	Terje Bergstrom <tbergstrom@nvidia.com>,
	"dri-devel\@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	xorg-devel@lists.x.org
Subject: Re: [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value
Date: Tue, 28 May 2013 13:12:12 -0600	[thread overview]
Message-ID: <86y5ay6hrn.fsf@miki.keithp.com> (raw)
In-Reply-To: <20130528103927.GB11547@mithrandir>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Thierry Reding <thierry.reding@gmail.com> writes:


> That doesn't sound right. Maybe drmIoctl() needs fixing instead. Looking
> at the history, drmIoctl() was introduced to automatically loop if a
> signal was received (commit 8b9ab108ec1f2ba2b503f713769c4946849b3cb2).
> However the ioctl(3p) manpage doesn't mention that ioctl() returns
> EAGAIN in case it is interrupted by a signal.

EAGAIN is being returned when the GPU is wedged to ask the application
to re-submit the request, which will presumably be held until the  GPU
is un-wedged.

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2013-05-28 19:12 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 11:49 [PATCH 0/6] Miscellaneous fixes to host1x Arto Merilainen
2013-05-17 11:49 ` Arto Merilainen
2013-05-17 11:49 ` [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value Arto Merilainen
2013-05-17 11:49   ` Arto Merilainen
     [not found]   ` <1368791388-31441-3-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:12     ` Thierry Reding
2013-05-26 10:12       ` Thierry Reding
2013-05-27  6:55       ` Arto Merilainen
2013-05-27  6:55         ` Arto Merilainen
     [not found]         ` <51A30372.6080907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-28 10:39           ` Thierry Reding
2013-05-28 10:39             ` Thierry Reding
2013-05-28 19:12             ` Keith Packard [this message]
2013-05-28 19:12               ` Keith Packard
     [not found]               ` <86y5ay6hrn.fsf-07MG1JmyPZaz9DMzp4kqnw@public.gmane.org>
2013-06-11 10:48                 ` Thierry Reding
2013-06-11 10:48                   ` Thierry Reding
2013-06-11 11:00                   ` Daniel Vetter
2013-06-11 11:00                     ` Daniel Vetter
2013-06-11 11:43                     ` Terje Bergström
2013-06-11 12:09                       ` Daniel Vetter
     [not found]                         ` <CAKMK7uGRW4uqsSaDEehTZwknZH+mNEgyKB6-4TgfgUOaTOcoLA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-11 18:19                           ` Thierry Reding
2013-06-11 18:19                             ` Thierry Reding
2013-06-12 10:28                         ` Terje Bergström
2013-06-12 11:00                           ` Daniel Vetter
     [not found] ` <1368791388-31441-1-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-17 11:49   ` [PATCH 1/6] gpu: host1x: Fixes to host1x firewall Arto Merilainen
2013-05-17 11:49     ` Arto Merilainen
     [not found]     ` <1368791388-31441-2-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:02       ` Thierry Reding
2013-05-26 10:02         ` Thierry Reding
2013-05-27  6:22         ` Arto Merilainen
2013-05-27  6:22           ` Arto Merilainen
2013-05-17 11:49   ` [PATCH 3/6] gpu: host1x: Fix memory access in syncpt request Arto Merilainen
2013-05-17 11:49     ` Arto Merilainen
     [not found]     ` <1368791388-31441-4-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:15       ` Thierry Reding
2013-05-26 10:15         ` Thierry Reding
2013-05-27  6:56         ` Arto Merilainen
2013-05-27  6:56           ` Arto Merilainen
2013-05-17 11:49   ` [PATCH 4/6] gpu: host1x: Fix client_managed type Arto Merilainen
2013-05-17 11:49     ` Arto Merilainen
     [not found]     ` <1368791388-31441-5-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:17       ` Thierry Reding
2013-05-26 10:17         ` Thierry Reding
2013-05-17 11:49 ` [PATCH 5/6] gpu: host1x: Rework CPU syncpoint increment Arto Merilainen
2013-05-17 11:49   ` Arto Merilainen
     [not found]   ` <1368791388-31441-6-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:24     ` Thierry Reding
2013-05-26 10:24       ` Thierry Reding
2013-05-17 11:49 ` [PATCH 6/6] drm/tegra: Fix syncpoint increment return code Arto Merilainen
2013-05-17 11:49   ` Arto Merilainen
     [not found]   ` <1368791388-31441-7-git-send-email-amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-26 10:26     ` Thierry Reding
2013-05-26 10:26       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y5ay6hrn.fsf@miki.keithp.com \
    --to=keithp@keithp.com \
    --cc=amerilainen@nvidia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=tbergstrom@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=xorg-devel@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.