From: Keith Packard <keithp@keithp.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add multi-threaded forcewake support
Date: Fri, 18 Nov 2011 14:01:00 -0800 [thread overview]
Message-ID: <86y5vdks4j.fsf@sumi.keithp.com> (raw)
In-Reply-To: <20111118113632.594717c8@jbarnes-desktop>
[-- Attachment #1.1: Type: text/plain, Size: 530 bytes --]
On Fri, 18 Nov 2011 11:36:32 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> + while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1))
You said this should be << 16
> + I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 1);
and this should be << 16 too
> + if (I915_READ(ECOBUS) & FORCEWAKE_MT_ENABLE) {
ECOBUS (0xa180) is zero on my machine, but I need the new functions.
Removing the ECOBUS check and switching the shifts to 16 makes this work
on my machine.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-11-18 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 19:36 [PATCH] drm/i915: add multi-threaded forcewake support Jesse Barnes
2011-11-18 22:01 ` Keith Packard [this message]
2011-11-18 22:12 ` Jesse Barnes
2011-11-18 22:35 ` Keith Packard
2011-11-18 22:48 ` Jesse Barnes
2011-11-18 23:27 ` Keith Packard
2011-11-18 23:34 ` Ben Widawsky
2011-11-19 5:33 ` Keith Packard
2011-11-21 15:47 ` Robert Hooker
[not found] <B32E3D5F1713054290B4FF257B89C51A2E8F496B66@shsmsx502.ccr.corp.intel.com>
2011-11-21 6:55 ` Fang, XunX
2011-12-05 22:42 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y5vdks4j.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.